[GitHub] [superset] stephenLYZ commented on a change in pull request #17792: feat: color consistency

[GitBox <gi...@apache.org>]

stephenLYZ commented on a change in pull request #17792:
URL: https://github.com/apache/superset/pull/17792#discussion_r780346316



##########
File path: superset-frontend/plugins/plugin-chart-echarts/src/Treemap/transformProps.ts
##########
@@ -259,7 +263,7 @@ export default function transformProps(
         show: false,
       },
       itemStyle: {
-        color: CategoricalColorNamespace.getColor(),
+        color: '#1FA8C9',

Review comment:
       The logic here is to display a default color when the treemap has no value, otherwise it is blank and the user may thinks it crashes. The previous way would generate a random color and give the scale an `undefined` key. That's way were wired.I think it is enough to write as one fixed color here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org