You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/02/01 19:57:16 UTC
[kudu-CR] build-support: fix reporting of build configuration
Hello Edward Fancher,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9182
to review the following change.
Change subject: build-support: fix reporting of build configuration
......................................................................
build-support: fix reporting of build configuration
Our older Jenkins setup for running flaky test builds seemed to use the
deprecated "build from the source root" setup with cmake. Now, we use a
build dir which isn't the same as the source root, which means we no
longer have a CMakeCache.txt in the source root.
This updates the test reporting to look for CMakeCache.txt in the proper
spot.
Change-Id: Ib6c131f46e75d2eb57d7e0ce9d2ad21e2ad9ab80
---
M build-support/report-test.sh
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/9182/1
--
To view, visit http://gerrit.cloudera.org:8080/9182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6c131f46e75d2eb57d7e0ce9d2ad21e2ad9ab80
Gerrit-Change-Number: 9182
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
[kudu-CR] build-support: fix reporting of build configuration
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9182 )
Change subject: build-support: fix reporting of build configuration
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c131f46e75d2eb57d7e0ce9d2ad21e2ad9ab80
Gerrit-Change-Number: 9182
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 06 Feb 2018 03:24:34 +0000
Gerrit-HasComments: No
[kudu-CR] build-support: fix reporting of build configuration
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9182 )
Change subject: build-support: fix reporting of build configuration
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c131f46e75d2eb57d7e0ce9d2ad21e2ad9ab80
Gerrit-Change-Number: 9182
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 06 Feb 2018 00:28:48 +0000
Gerrit-HasComments: No
[kudu-CR] build-support: fix reporting of build configuration
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9182 )
Change subject: build-support: fix reporting of build configuration
......................................................................
build-support: fix reporting of build configuration
Our older Jenkins setup for running flaky test builds seemed to use the
deprecated "build from the source root" setup with cmake. Now, we use a
build dir which isn't the same as the source root, which means we no
longer have a CMakeCache.txt in the source root.
This updates the test reporting to look for CMakeCache.txt in the proper
spot.
Change-Id: Ib6c131f46e75d2eb57d7e0ce9d2ad21e2ad9ab80
Reviewed-on: http://gerrit.cloudera.org:8080/9182
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Grant Henke <gr...@gmail.com>
---
M build-support/report-test.sh
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Hao Hao: Looks good to me, but someone else must approve
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6c131f46e75d2eb57d7e0ce9d2ad21e2ad9ab80
Gerrit-Change-Number: 9182
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Edward Fancher <ef...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>