You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Eric Sammer <es...@cloudera.com> on 2011/12/24 21:39:37 UTC
Review Request: FLUME-833: Audit Direct Library Deps for Flume NG
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3315/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
* Updated all versions (where it didn't break compatibility).
* Updated plugin and dep management to include all versions.
* Removed explicit versions in modules.
Note that this is based on FLUME-902 because it dealt with thrift.
This addresses bug FLUME-833.
https://issues.apache.org/jira/browse/FLUME-833
Diffs
-----
c/flume-ng-core/pom.xml 2726b06
c/flume-ng-node/pom.xml a5a2ae5
c/pom.xml 3a177f0
Diff: https://reviews.apache.org/r/3315/diff
Testing
-------
Thanks,
Eric
Re: Review Request: FLUME-833: Audit Direct Library Deps for Flume NG
Posted by Eric Sammer <es...@cloudera.com>.
> On 2011-12-27 18:18:29, Arvind Prabhakar wrote:
> > Eric, can you please rebase the patch and update the review? I am not able to apply it cleanly on a fresh checkout.
See above. :)
It's based on FLUME-902. You need to apply 902 first and then 833 and it should apply cleanly.
- Eric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3315/#review4123
-----------------------------------------------------------
On 2011-12-24 20:39:37, Eric Sammer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3315/
> -----------------------------------------------------------
>
> (Updated 2011-12-24 20:39:37)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> * Updated all versions (where it didn't break compatibility).
> * Updated plugin and dep management to include all versions.
> * Removed explicit versions in modules.
>
> Note that this is based on FLUME-902 because it dealt with thrift.
>
>
> This addresses bug FLUME-833.
> https://issues.apache.org/jira/browse/FLUME-833
>
>
> Diffs
> -----
>
> c/flume-ng-core/pom.xml 2726b06
> c/flume-ng-node/pom.xml a5a2ae5
> c/pom.xml 3a177f0
>
> Diff: https://reviews.apache.org/r/3315/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric
>
>
Re: Review Request: FLUME-833: Audit Direct Library Deps for Flume NG
Posted by Arvind Prabhakar <ar...@apache.org>.
> On 2011-12-27 18:18:29, Arvind Prabhakar wrote:
> > Eric, can you please rebase the patch and update the review? I am not able to apply it cleanly on a fresh checkout.
>
> Eric Sammer wrote:
> See above. :)
>
> It's based on FLUME-902. You need to apply 902 first and then 833 and it should apply cleanly.
I actually did that and it did not work for me. One possible issue could be that the patch was generated without the --no-prefix option. I will try to modify the patch to remove the prefixes and see if that works.
- Arvind
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3315/#review4123
-----------------------------------------------------------
On 2011-12-24 20:39:37, Eric Sammer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3315/
> -----------------------------------------------------------
>
> (Updated 2011-12-24 20:39:37)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> * Updated all versions (where it didn't break compatibility).
> * Updated plugin and dep management to include all versions.
> * Removed explicit versions in modules.
>
> Note that this is based on FLUME-902 because it dealt with thrift.
>
>
> This addresses bug FLUME-833.
> https://issues.apache.org/jira/browse/FLUME-833
>
>
> Diffs
> -----
>
> c/flume-ng-core/pom.xml 2726b06
> c/flume-ng-node/pom.xml a5a2ae5
> c/pom.xml 3a177f0
>
> Diff: https://reviews.apache.org/r/3315/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric
>
>
Re: Review Request: FLUME-833: Audit Direct Library Deps for Flume NG
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3315/#review4123
-----------------------------------------------------------
Eric, can you please rebase the patch and update the review? I am not able to apply it cleanly on a fresh checkout.
- Arvind
On 2011-12-24 20:39:37, Eric Sammer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3315/
> -----------------------------------------------------------
>
> (Updated 2011-12-24 20:39:37)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> * Updated all versions (where it didn't break compatibility).
> * Updated plugin and dep management to include all versions.
> * Removed explicit versions in modules.
>
> Note that this is based on FLUME-902 because it dealt with thrift.
>
>
> This addresses bug FLUME-833.
> https://issues.apache.org/jira/browse/FLUME-833
>
>
> Diffs
> -----
>
> c/flume-ng-core/pom.xml 2726b06
> c/flume-ng-node/pom.xml a5a2ae5
> c/pom.xml 3a177f0
>
> Diff: https://reviews.apache.org/r/3315/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric
>
>
Re: Review Request: FLUME-833: Audit Direct Library Deps for Flume NG
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3315/#review4130
-----------------------------------------------------------
Ship it!
+1
Verified that the build passes with a clean maven cache.
- Arvind
On 2011-12-24 20:39:37, Eric Sammer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3315/
> -----------------------------------------------------------
>
> (Updated 2011-12-24 20:39:37)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> * Updated all versions (where it didn't break compatibility).
> * Updated plugin and dep management to include all versions.
> * Removed explicit versions in modules.
>
> Note that this is based on FLUME-902 because it dealt with thrift.
>
>
> This addresses bug FLUME-833.
> https://issues.apache.org/jira/browse/FLUME-833
>
>
> Diffs
> -----
>
> c/flume-ng-core/pom.xml 2726b06
> c/flume-ng-node/pom.xml a5a2ae5
> c/pom.xml 3a177f0
>
> Diff: https://reviews.apache.org/r/3315/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric
>
>