You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/07 08:06:37 UTC
[GitHub] [doris] starocean999 opened a new pull request, #14883: [fix](nereids)having with no group by is not parsed correctly
starocean999 opened a new pull request, #14883:
URL: https://github.com/apache/doris/pull/14883
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #14883: [fix](nereids)having with no group by is not parsed correctly
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #14883:
URL: https://github.com/apache/doris/pull/14883#discussion_r1045849524
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/FillUpMissingSlots.java:
##########
@@ -120,7 +120,10 @@ public List<Rule> buildRules() {
having.getPredicates(), r.getSubstitution());
return new LogicalFilter<>(newPredicates, a);
});
- })
+ })),
+ RuleType.FILL_UP_HAVING_PROJECT.build(
Review Comment:
rule's name is better called `HAVING_TO_FILTER`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14883: [fix](nereids)having with no group by is not parsed correctly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14883:
URL: https://github.com/apache/doris/pull/14883#issuecomment-1346549444
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #14883: [fix](nereids)having with no group by is not parsed correctly
Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #14883:
URL: https://github.com/apache/doris/pull/14883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14883: [fix](nereids)having with no group by is not parsed correctly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14883:
URL: https://github.com/apache/doris/pull/14883#issuecomment-1346549488
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14883: [fix](nereids)having with no group by is not parsed correctly
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14883:
URL: https://github.com/apache/doris/pull/14883#issuecomment-1340709877
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.53 seconds
load time: 453 seconds
storage size: 17123356239 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221207101824_clickbench_pr_59250.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org