[jira] [Commented] (HIVE-16330) Improve plans for scalar subquery with aggregates

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-16330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002463#comment-16002463 ] 

Hive QA commented on HIVE-16330:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12867015/HIVE-16330.1.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 10655 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar] (batchId=149)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_select] (batchId=149)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=143)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_join30] (batchId=148)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[subquery_scalar_corr_multi_rows] (batchId=88)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query1] (batchId=230)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query30] (batchId=230)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query6] (batchId=230)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query81] (batchId=230)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query9] (batchId=230)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5132/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5132/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5132/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 10 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12867015 - PreCommit-HIVE-Build

> Improve plans for scalar subquery with aggregates
> -------------------------------------------------
>
>                 Key: HIVE-16330
>                 URL: https://issues.apache.org/jira/browse/HIVE-16330
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Vineet Garg
>            Assignee: Vineet Garg
>         Attachments: HIVE-16330.1.patch
>
>
> Scalar subquery plans are generated with a count(*) on subquery which is fed to {{sq_count_check}} UDF. This is to make sure at runtime that there is at most one row generated by scalar subquery. 
> We can avoid generating this extra count(*) for scalar subqueries with aggregates and windowing since such queries are guaranteed to generate at most one row. e.g. {code:SQL} select * from part where p_size > (select max(p_size) from part) {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)