You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/02/18 02:36:12 UTC
Review Request 31143: AMS : Kafka Metrics - Log flush status metrics
do not show up.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31143/
-----------------------------------------------------------
Review request for Ambari, Artem Baranchuk, Dmytro Sen, Erik Bergenholtz, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-9612
https://issues.apache.org/jira/browse/AMBARI-9612
Repository: ambari
Description
-------
Feeding the data into AMS in legacy format
Diffs
-----
ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 762b5f22d9983bf2b36a4b985302ef05d7ba5018
Diff: https://reviews.apache.org/r/31143/diff/
Testing
-------
mvn clean test
deployed the Kafka sink jar in a local Ambari cluster -> log flush metrics show ok
Thanks,
Florian Barca
Re: Review Request 31143: AMS : Kafka Metrics - Log flush status
metrics do not show up.
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31143/#review72940
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Фев. 18, 2015, 1:36 д.п., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31143/
> -----------------------------------------------------------
>
> (Updated Фев. 18, 2015, 1:36 д.п.)
>
>
> Review request for Ambari, Artem Baranchuk, Dmytro Sen, Erik Bergenholtz, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-9612
> https://issues.apache.org/jira/browse/AMBARI-9612
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Feeding the data into AMS in legacy format
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 762b5f22d9983bf2b36a4b985302ef05d7ba5018
>
> Diff: https://reviews.apache.org/r/31143/diff/
>
>
> Testing
> -------
>
> mvn clean test
> deployed the Kafka sink jar in a local Ambari cluster -> log flush metrics show ok
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 31143: AMS : Kafka Metrics - Log flush status
metrics do not show up.
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31143/#review72869
-----------------------------------------------------------
ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
<https://reviews.apache.org/r/31143/#comment118990>
This call to cacheKafkaMetered() is the actual fix. Still, the data seems fabricated at this point.
- Florian Barca
On Feb. 18, 2015, 1:36 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31143/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 1:36 a.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Dmytro Sen, Erik Bergenholtz, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-9612
> https://issues.apache.org/jira/browse/AMBARI-9612
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Feeding the data into AMS in legacy format
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 762b5f22d9983bf2b36a4b985302ef05d7ba5018
>
> Diff: https://reviews.apache.org/r/31143/diff/
>
>
> Testing
> -------
>
> mvn clean test
> deployed the Kafka sink jar in a local Ambari cluster -> log flush metrics show ok
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 31143: AMS : Kafka Metrics - Log flush status
metrics do not show up.
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31143/#review72920
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Лют. 18, 2015, 3:36 до полудня, Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31143/
> -----------------------------------------------------------
>
> (Updated Лют. 18, 2015, 3:36 до полудня)
>
>
> Review request for Ambari, Artem Baranchuk, Dmytro Sen, Erik Bergenholtz, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-9612
> https://issues.apache.org/jira/browse/AMBARI-9612
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Feeding the data into AMS in legacy format
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 762b5f22d9983bf2b36a4b985302ef05d7ba5018
>
> Diff: https://reviews.apache.org/r/31143/diff/
>
>
> Testing
> -------
>
> mvn clean test
> deployed the Kafka sink jar in a local Ambari cluster -> log flush metrics show ok
>
>
> Thanks,
>
> Florian Barca
>
>