You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2021/10/25 08:49:48 UTC

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

weichiu@apache.org has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17963


Change subject: IMPALA-10212. Support ofs scheme.
......................................................................

IMPALA-10212. Support ofs scheme.

OFS is the new file system implementation for Ozone.
The biggest difference compared to o3fs is that ofs supports operations across all
volumes and buckets and provides a full view of all the volume/buckets.

It uses the same transport as o3fs and therefore it shares the thread pool with o3fs.

Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
---
M be/src/util/hdfs-util.cc
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java
3 files changed, 16 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/17963/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <we...@apache.org>

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17963 )

Change subject: IMPALA-10212. Support ofs scheme.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

This looks good to me. Thanks for putting this together. I had one minor nit.

http://gerrit.cloudera.org:8080/#/c/17963/2/fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java
File fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java:

http://gerrit.cloudera.org:8080/#/c/17963/2/fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java@121
PS2, Line 121:     // testIsSupportStorageIds(mockLocation(FileSystemUtil.SCHEME_O3FS), true);
Nit: There are a few of these commented out O3FS tests that we would like to enable later. Can you add an OFS equivalent for each one (still commented out)?



-- 
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Oct 2021 17:37:26 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17963 )

Change subject: IMPALA-10212. Support ofs scheme.
......................................................................


Patch Set 2:

> good idea. patch updated.

I'm not seeing a new patch on Gerrit, did that get uploaded?


-- 
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Oct 2021 16:32:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.

Hello Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/17963

to look at the new patch set (#2).

Change subject: IMPALA-10212. Support ofs scheme.
......................................................................

IMPALA-10212. Support ofs scheme.

OFS is the new file system implementation for Ozone.
The biggest difference compared to o3fs is that ofs supports operations across all
volumes and buckets and provides a full view of all the volume/buckets.

It uses the same transport as o3fs and therefore it shares the thread pool with o3fs.

How it was tested:
The patch was tested manually on a CDPD cluster, loaded TPC-DS data, ran TPC-DS, ran 'load data inpath' command.

Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
---
M be/src/util/hdfs-util.cc
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java
3 files changed, 16 insertions(+), 3 deletions(-)

git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/17963/2
--
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has uploaded a new patch set (#4) to the change originally created by weichiu@apache.org. ( http://gerrit.cloudera.org:8080/17963 )

Change subject: IMPALA-10212. Support ofs scheme.
......................................................................

IMPALA-10212. Support ofs scheme.

It uses the same transport as o3fs and therefore it shares the thread pool with o3fs.

How it was tested:
The patch was tested manually on a CDPD cluster, loaded TPC-DS data, ran TPC-DS, ran 'load data inpath' command.

git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/17963/4
--
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17963 )

Change subject: IMPALA-10212. Support ofs scheme.
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9646/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Oct 2021 09:12:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17963 )

Change subject: IMPALA-10212. Support ofs scheme.
......................................................................

IMPALA-10212. Support ofs scheme.

It uses the same transport as o3fs and therefore it shares the thread pool with o3fs.

How it was tested:
The patch was tested manually on a CDPD cluster, loaded TPC-DS data, ran TPC-DS, ran 'load data inpath' command.

Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Reviewed-on: http://gerrit.cloudera.org:8080/17963
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/hdfs-util.cc
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java
3 files changed, 19 insertions(+), 3 deletions(-)

Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17963 )

Change subject: IMPALA-10212. Support ofs scheme.
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9665/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Oct 2021 17:11:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17963 )

Change subject: IMPALA-10212. Support ofs scheme.
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9664/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Oct 2021 17:08:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has uploaded a new patch set (#3) to the change originally created by weichiu@apache.org. ( http://gerrit.cloudera.org:8080/17963 )

Change subject: IMPALA-10212. Support ofs scheme.
......................................................................

IMPALA-10212. Support ofs scheme.

It uses the same transport as o3fs and therefore it shares the thread pool with o3fs.

How it was tested:
The patch was tested manually on a CDPD cluster, loaded TPC-DS data, ran TPC-DS, ran 'load data inpath' command.

git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/17963/3
--
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17963 )

Change subject: IMPALA-10212. Support ofs scheme.
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Oct 2021 23:03:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.

weichiu@apache.org has posted comments on this change. ( http://gerrit.cloudera.org:8080/17963 )

Change subject: IMPALA-10212. Support ofs scheme.
......................................................................


Patch Set 2:

good idea. patch updated.


-- 
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Oct 2021 01:30:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17963 )

Change subject: IMPALA-10212. Support ofs scheme.
......................................................................


Patch Set 4: Code-Review+2

Alright, this is looking good, I'm going to kick off the precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Oct 2021 16:51:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17963 )

Change subject: IMPALA-10212. Support ofs scheme.
......................................................................


Patch Set 1:

> > good idea. patch updated.
 > 
 > I'm not seeing a new patch on Gerrit, did that get uploaded?

Oh, nevermind, I see it. I will squash them together and post a combined patch to this review.


-- 
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Oct 2021 16:32:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10212. Support ofs scheme.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17963 )

Change subject: IMPALA-10212. Support ofs scheme.
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7568/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69908f65c97f40ff01b25d6d6db53c37a9e978ba
Gerrit-Change-Number: 17963
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Anonymous Coward <we...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Oct 2021 16:51:25 +0000
Gerrit-HasComments: No