You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/07 10:04:36 UTC
[GitHub] [kafka] chia7712 opened a new pull request #9257: KAFKA-10463 the necessary utilities in Dockerfile should include git
chia7712 opened a new pull request #9257:
URL: https://github.com/apache/kafka/pull/9257
issue: https://issues.apache.org/jira/browse/KAFKA-10463
the default image of Dockerfile is ```openjdk:8``` and it pre-installed git so it is fine that necessary utilities does not include git. However, the later version of openjdk image does not include git by default and error message "git: command not found" ensues.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9257: KAFKA-10463 the necessary utilities in Dockerfile should include git
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9257:
URL: https://github.com/apache/kafka/pull/9257#issuecomment-689265404
@ijuma Could you take a look? I want to run system test on different jdk. I configure ```jdk_version``` to change the os of kafka dockerfile. Without this patch, it is impossible to switch to other popular jdk images (for example, openjdk:11 and azul/zulu-openjdk:11) quickly since the ```git``` is not installed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #9257: KAFKA-10463 the necessary utilities in Dockerfile should include git
Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #9257:
URL: https://github.com/apache/kafka/pull/9257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #9257: KAFKA-10463 the necessary utilities in Dockerfile should include git
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9257:
URL: https://github.com/apache/kafka/pull/9257#issuecomment-689590183
Thanks for the PR. Can you please add a comment explaining that `git` is included in openjdk:8, but not openjdk:11?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9257: KAFKA-10463 the necessary utilities in Dockerfile should include git
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9257:
URL: https://github.com/apache/kafka/pull/9257#issuecomment-689608467
> Can you please add a comment explaining that git is included in openjdk:8, but not openjdk:11?
done. Thanks for reviews!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org