You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2014/08/30 15:38:41 UTC

[Bug 56900] New: Resource Leaks found by CID 45266 and 45249

https://issues.apache.org/bugzilla/show_bug.cgi?id=56900

            Bug ID: 56900
           Summary: Resource Leaks found by CID 45266 and 45249
           Product: Tomcat 8
           Version: trunk
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: felix.schumacher@internetallee.de

Created attachment 31953
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31953&action=edit
Close InputStream after use. Factor out common code into a private method.

InputStreams are not closed after using them for loading the content into
properties.

This happens a few times in the code base and seems to be a common task. Maybe
we should create a utility-method to capsulate that funtion.

For DefaultInstanceManager I have created a private method. For ContextConfig I
adapted to local logic only.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56900] Resource Leaks found by CID 45266 and 45249

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56900

--- Comment #1 from Felix Schumacher <fe...@internetallee.de> ---
Created attachment 31954
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31954&action=edit
Close InputStream after use in ContextConfig

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56900] Resource Leaks found by CID 45266 and 45249

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56900

--- Comment #3 from Violeta Georgieva <vi...@apache.org> ---
Fix is committed to 7.0.x and will be available in 7.0.56 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56900] Resource Leaks found by CID 45266 and 45249

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56900

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Mark Thomas <ma...@apache.org> ---
Thanks for the patches. I applied a variation of them (I used try with
resources to reduce the code) to 8.0.x and this will be included in 8.0.13
onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org