You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/18 17:58:26 UTC
[GitHub] [tvm] ashutosh-arm opened a new pull request #9963: [CMSIS-NN] Separated symmetric and asymmetric padding tests for Conv2D
ashutosh-arm opened a new pull request #9963:
URL: https://github.com/apache/tvm/pull/9963
* Separated asymmetric padding test from others.
This is a follow up from https://github.com/apache/tvm/pull/9886.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ashutosh-arm commented on pull request #9963: [CMSIS-NN] Separated symmetric and asymmetric padding tests for Conv2D
Posted by GitBox <gi...@apache.org>.
ashutosh-arm commented on pull request #9963:
URL: https://github.com/apache/tvm/pull/9963#issuecomment-1016264211
CC: @Mousius @grant-arm for code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius merged pull request #9963: [CMSIS-NN] Separated symmetric and asymmetric padding tests for Conv2D
Posted by GitBox <gi...@apache.org>.
Mousius merged pull request #9963:
URL: https://github.com/apache/tvm/pull/9963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on a change in pull request #9963: [CMSIS-NN] Separated symmetric and asymmetric padding tests for Conv2D
Posted by GitBox <gi...@apache.org>.
Mousius commented on a change in pull request #9963:
URL: https://github.com/apache/tvm/pull/9963#discussion_r787563983
##########
File path: tests/python/contrib/test_cmsisnn/test_conv2d.py
##########
@@ -124,7 +124,113 @@ def make_model(
@tvm.testing.requires_cmsisnn
-@pytest.mark.parametrize("ifm_shape", [(1, 25, 25, 12), (1, 64, 100, 4)])
+@pytest.mark.parametrize("ifm_shape", [(1, 64, 100, 4)])
+@pytest.mark.parametrize("kernel_size", [(3, 3)])
+@pytest.mark.parametrize("padding", ["SAME", "VALID"])
+@pytest.mark.parametrize("strides, dilation", [((1, 1), (1, 1))])
+@pytest.mark.parametrize("relu_type", ["RELU"])
Review comment:
Make these variables instead of parametrize so it's clear they don't change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ashutosh-arm commented on a change in pull request #9963: [CMSIS-NN] Separated symmetric and asymmetric padding tests for Conv2D
Posted by GitBox <gi...@apache.org>.
ashutosh-arm commented on a change in pull request #9963:
URL: https://github.com/apache/tvm/pull/9963#discussion_r787611936
##########
File path: tests/python/contrib/test_cmsisnn/test_conv2d.py
##########
@@ -124,7 +124,113 @@ def make_model(
@tvm.testing.requires_cmsisnn
-@pytest.mark.parametrize("ifm_shape", [(1, 25, 25, 12), (1, 64, 100, 4)])
+@pytest.mark.parametrize("ifm_shape", [(1, 64, 100, 4)])
+@pytest.mark.parametrize("kernel_size", [(3, 3)])
+@pytest.mark.parametrize("padding", ["SAME", "VALID"])
+@pytest.mark.parametrize("strides, dilation", [((1, 1), (1, 1))])
+@pytest.mark.parametrize("relu_type", ["RELU"])
Review comment:
Made the change. Let's see how the checks go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org