[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10528: PinotBufferFactory and a buffer implementation that uses Unsafe

["xiangfu0 (via GitHub)" <gi...@apache.org>]

xiangfu0 commented on code in PR #10528:
URL: https://github.com/apache/pinot/pull/10528#discussion_r1208365787


##########
.github/workflows/pinot_tests.yml:
##########
@@ -72,16 +72,20 @@ jobs:
     if: github.repository == 'apache/pinot'
     runs-on: ubuntu-latest
     strategy:
+      # Changed to false in order to improve coverage using unsafe buffers
+      fail-fast: false
       matrix:
         testset: [ 1, 2 ]
-    name: Pinot Unit Test Set ${{ matrix.testset }}
+        java: [ 11, 17 ]

Review Comment:
   do you want to add java 20 here as well?



##########
.github/workflows/pinot_tests.yml:
##########
@@ -120,16 +124,20 @@ jobs:
     if: github.repository == 'apache/pinot'
     runs-on: ubuntu-latest
     strategy:
+      # Changed to false in order to improve coverage using unsafe buffers
+      fail-fast: false
       matrix:
         testset: [ 1, 2 ]
-    name: Pinot Integration Test Set ${{ matrix.testset }}
+        java: [ 11, 17, 20 ]
+        distribution: [ "temurin" ]
+    name: Pinot Integration Test Set ${{ matrix.testset }} (${{matrix.distribution}}-${{matrix.java}})
     steps:
       - uses: actions/checkout@v3
       - name: Set up JDK 11

Review Comment:
   Set up JDK ${{ matrix.java }}



##########
.github/workflows/pinot_tests.yml:
##########
@@ -72,16 +72,20 @@ jobs:
     if: github.repository == 'apache/pinot'
     runs-on: ubuntu-latest
     strategy:
+      # Changed to false in order to improve coverage using unsafe buffers
+      fail-fast: false
       matrix:
         testset: [ 1, 2 ]
-    name: Pinot Unit Test Set ${{ matrix.testset }}
+        java: [ 11, 17 ]
+        distribution: [ "temurin" ]
+    name: Pinot Unit Test Set ${{ matrix.testset }} (${{matrix.distribution}}-${{matrix.java}})
     steps:
       - uses: actions/checkout@v3
       - name: Set up JDK 11

Review Comment:
   `Set up JDK ${{ matrix.java }}`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org