You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/10/24 05:36:07 UTC
[GitHub] [incubator-kyuubi] turboFei opened a new pull request, #3684: Expose the engine id and show the engine details for list engine command
turboFei opened a new pull request, #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#discussion_r1009250389
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -92,6 +92,10 @@ class SparkTBinaryFrontendService(
None
}
}
+
+ override def extraServiceInfo: Map[String, String] = {
Review Comment:
> why extra is added? do we have an info method?
I did not get it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#issuecomment-1301693129
thanks for the review, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei closed pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #3684: Expose the engine id when registering and show the engine details for list engine command
URL: https://github.com/apache/incubator-kyuubi/pull/3684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#discussion_r1003105110
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -92,6 +92,10 @@ class SparkTBinaryFrontendService(
None
}
}
+
+ override def extraServiceInfo: Map[String, String] = {
Review Comment:
<img width="859" alt="image" src="https://user-images.githubusercontent.com/6757692/197497450-0df9f7e4-21ce-4268-978d-17fdabb4dd1f.png">
Now I can see the `KYUUBI_ENGINE_ID` is only used in Spark.
We can extend other engines to support expose kyuubi.engine.id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zwangsheng commented on a diff in pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on code in PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#discussion_r1003178848
##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/zookeeper/ZookeeperDiscoveryClient.scala:
##########
@@ -342,9 +351,12 @@ class ZookeeperDiscoveryClient(conf: KyuubiConf) extends DiscoveryClient {
val session = conf.get(HA_ENGINE_REF_ID)
.map(refId => s"refId=$refId;").getOrElse("")
+ val extraInfo =
+ extraServiceInfo.map(kv => kv._1 + "=" + kv._2).mkString(";", ";", "").stripSuffix(";")
val pathPrefix = ZKPaths.makePath(
namespace,
- s"serviceUri=$instance;version=${version.getOrElse(KYUUBI_VERSION)};${session}sequence=")
+ s"serviceUri=$instance;version=${version.getOrElse(KYUUBI_VERSION)}" +
+ s"$extraInfo;${session}sequence=")
Review Comment:
we need `;` here to split version and extraInfo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#discussion_r1003309733
##########
kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/api/v1/dto/Engine.java:
##########
@@ -40,14 +43,16 @@ public Engine(
String sharelevel,
String subdomain,
String instance,
- String namespace) {
+ String namespace,
+ Map<String, String> details) {
Review Comment:
all the info saved in the engine discovery node.
version, sequence, engineId and so on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#issuecomment-1296880630
cc @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#discussion_r1003180343
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -92,6 +92,10 @@ class SparkTBinaryFrontendService(
None
}
}
+
+ override def extraServiceInfo: Map[String, String] = {
Review Comment:
why extra is added? do we have an info method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#discussion_r1003096498
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -92,6 +92,10 @@ class SparkTBinaryFrontendService(
None
}
}
+
+ override def extraServiceInfo: Map[String, String] = {
Review Comment:
why is spark special?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#issuecomment-1289026336
> why do need this?
We now support to list engines with kyuubi-admin command line.
And we need more insight for the engine information.
https://github.com/apache/incubator-kyuubi/pull/3680
> why do we expose it in this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#discussion_r1003095382
##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/zookeeper/ZookeeperDiscoveryClient.scala:
##########
@@ -342,9 +351,12 @@ class ZookeeperDiscoveryClient(conf: KyuubiConf) extends DiscoveryClient {
val session = conf.get(HA_ENGINE_REF_ID)
.map(refId => s"refId=$refId;").getOrElse("")
+ val extraInfo =
+ extraServiceInfo.map(kv => kv._1 + "=" + kv._2).mkString(";", ";", "").stripSuffix(";")
val pathPrefix = ZKPaths.makePath(
namespace,
- s"serviceUri=$instance;version=${version.getOrElse(KYUUBI_VERSION)};${session}sequence=")
Review Comment:
what else will be added to to path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#discussion_r1003105110
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -92,6 +92,10 @@ class SparkTBinaryFrontendService(
None
}
}
+
+ override def extraServiceInfo: Map[String, String] = {
Review Comment:
<img width="859" alt="image" src="https://user-images.githubusercontent.com/6757692/197497450-0df9f7e4-21ce-4268-978d-17fdabb4dd1f.png">
Now I can only see the `KYUUBI_ENGINE_ID` is used in Spark.
We can extend other engines to support expose kyuubi.engine.id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#discussion_r1003107625
##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/zookeeper/ZookeeperDiscoveryClient.scala:
##########
@@ -342,9 +351,12 @@ class ZookeeperDiscoveryClient(conf: KyuubiConf) extends DiscoveryClient {
val session = conf.get(HA_ENGINE_REF_ID)
.map(refId => s"refId=$refId;").getOrElse("")
+ val extraInfo =
+ extraServiceInfo.map(kv => kv._1 + "=" + kv._2).mkString(";", ";", "").stripSuffix(";")
val pathPrefix = ZKPaths.makePath(
namespace,
- s"serviceUri=$instance;version=${version.getOrElse(KYUUBI_VERSION)};${session}sequence=")
Review Comment:
now only the kyuubi.engine.id is added.
Maybe we can add more info.
such as kyuubi.engine.url and kyuubi.engine.name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#issuecomment-1288866861
2 general questions
- why do need this?
- why do we exposing in such a way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#discussion_r1009252782
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -92,6 +92,10 @@ class SparkTBinaryFrontendService(
None
}
}
+
+ override def extraServiceInfo: Map[String, String] = {
Review Comment:
The extra is to distinguish w/ the service host/port information, if it's confusing, I suggest naming it attributes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zwangsheng commented on a diff in pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on code in PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#discussion_r1003178848
##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/zookeeper/ZookeeperDiscoveryClient.scala:
##########
@@ -342,9 +351,12 @@ class ZookeeperDiscoveryClient(conf: KyuubiConf) extends DiscoveryClient {
val session = conf.get(HA_ENGINE_REF_ID)
.map(refId => s"refId=$refId;").getOrElse("")
+ val extraInfo =
+ extraServiceInfo.map(kv => kv._1 + "=" + kv._2).mkString(";", ";", "").stripSuffix(";")
val pathPrefix = ZKPaths.makePath(
namespace,
- s"serviceUri=$instance;version=${version.getOrElse(KYUUBI_VERSION)};${session}sequence=")
+ s"serviceUri=$instance;version=${version.getOrElse(KYUUBI_VERSION)}" +
+ s"$extraInfo;${session}sequence=")
Review Comment:
we need `;` here to split version and extraInfo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#issuecomment-1288725997
why a engine id means more information？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#issuecomment-1289029201
> why do we expose it in this way?
It is compatible with before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#issuecomment-1288709255
```
AdminResourceSuite:
- refresh Hadoop configuration of the kyuubi server
- delete engine - user share level *** FAILED ***
List("serviceUri=localhost:40419;version=1.7.0-SNAPSHOT;kyuubi.engine.id=local-1666594567035;refId=823f7053-4ec6-4eaf-8521-3dc209393673;sequence=0000000000") had size 1 instead of expected size 0 (AdminResourceSuite.scala:103)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3684: Expose the engine id when registering and show the engine details for list engine command
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3684:
URL: https://github.com/apache/incubator-kyuubi/pull/3684#discussion_r1003182203
##########
kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/api/v1/dto/Engine.java:
##########
@@ -40,14 +43,16 @@ public Engine(
String sharelevel,
String subdomain,
String instance,
- String namespace) {
+ String namespace,
+ Map<String, String> details) {
Review Comment:
what does details stand for?
##########
kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/api/v1/dto/Engine.java:
##########
@@ -40,14 +43,16 @@ public Engine(
String sharelevel,
String subdomain,
String instance,
- String namespace) {
+ String namespace,
+ Map<String, String> details) {
Review Comment:
what do details stand for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org