[GitHub] [lucene-solr] Traktormaster commented on issue #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

[GitBox <gi...@apache.org>]

Traktormaster commented on issue #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left
URL: https://github.com/apache/lucene-solr/pull/1123#issuecomment-569408594
 
 
   Basically the whole patch has been reworked, here are the highlights:
   - About half as many calls to `preceding()` and `following()` on the wrapped BI.
   - `fragsize` is about the length of the contextual text around the match. (it's relation to the snippet size is indirect)
   - `fragalign` has been renamed to `fragAlignRatio`. Changed it's default value to `0.5`.
   - Made the hidden `closestTo/targetLen` mode the default instead of `minimumLen`. This adds an automatic slop-like behaviour.
   - The new parameter `fragsizeIsMinimum` can be used to switch back to the previously used mode. (minimum mode is a little faster)
   - Changed the call of `following(start)` in `FieldHighlighter` to `following(end - 1)` for performance and correctness.
   - Tests and docs have been updated.
   
   With these defaults the UH will give more meaingful results as-is. To have even more similar results to the older highlighters the `hl.bs.type` can be switched to `WORD`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org