[jira] [Updated] (HADOOP-12344) validateSocketPathSecurity0 message could be better

["Casey Brotherton (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Casey Brotherton updated HADOOP-12344:
--------------------------------------
    Attachment: HADOOP-12344.003.patch

Three copies of the newIOexception.

Also noticed and fixed a minor defect in the unit test.

It checks "/foo"  off of the root directory to determine if the root
directory is secure, as it should be owned by root, and not world writable.

It does not fail, if you change the permissions of / to be world writable.

Made a change to the skipComponents parameter that seems to fix the behaviour, and fail correctly while passing with normal root permissions.

> validateSocketPathSecurity0 message could be better
> ---------------------------------------------------
>
>                 Key: HADOOP-12344
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12344
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: net
>            Reporter: Casey Brotherton
>            Assignee: Casey Brotherton
>            Priority: Trivial
>         Attachments: HADOOP-12344.001.patch, HADOOP-12344.002.patch, HADOOP-12344.003.patch, HADOOP-12344.patch
>
>
> When a socket path does not have the correct permissions, an error is thrown.
> That error just has the failing component of the path and not the entire path of the socket.
> The entire path of the socket could be printed out to allow for a direct check of the permissions of the entire path.
> {code}
> java.io.IOException: the path component: '/' is world-writable.  Its permissions are 0077.  Please fix this or select a different socket path.
> 	at org.apache.hadoop.net.unix.DomainSocket.validateSocketPathSecurity0(Native Method)
> 	at org.apache.hadoop.net.unix.DomainSocket.bindAndListen(DomainSocket.java:189)
> ...
> {code}
> The error message could also provide the socket path:
> {code}
> java.io.IOException: the path component: '/' is world-writable.  Its permissions are 0077.  Please fix this or select a different socket path than '/var/run/hdfs-sockets/dn'
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)