You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2016/05/26 12:35:26 UTC

[GitHub] flink pull request: [FLINK-3908] Fixed Parser's error state reset

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/2007#issuecomment-221858427
  
    Thanks for addressing this bug!
    
    How about slightly changing the names of the methods:
      - The method that resets the error state and parses would be called `resetErrorStateAndParse(...)`. That would make it clear what happens.
      - The `parseFieldImpl(...)` could be kept as `parseField(...)`
      - The `GenericCsvInputCormat` would call the `resetErrorStateAndParse(...)` method.
    
    Other than that, solution looks good!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---