You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/12 20:57:07 UTC
[GitHub] [airflow] potiuk opened a new pull request, #28316: Bring back psycopg2-binary as dependency instead of psycopg
potiuk opened a new pull request, #28316:
URL: https://github.com/apache/airflow/pull/28316
The psycopg dependency is slightly more optimized than than the binary one, but the problems it creates when it is used as dependency are numerous - it always expects to compile the psycopg dependencies, so you cannot install it when there are no build-essentials installed and on some systems additional libraries are needed.
We introduced it in #25710 for optimisation reasons.
However, the optimisations it brings are not really justified with the installation complexities it introduces, that's why we revert it.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28316: Bring back psycopg2-binary as dependency instead of psycopg
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28316:
URL: https://github.com/apache/airflow/pull/28316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #28316: Bring back psycopg2-binary as dependency instead of psycopg
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on PR #28316:
URL: https://github.com/apache/airflow/pull/28316#issuecomment-1347375063
Saw your convo on Slack, looks like a pretty straight-forward PR :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org