You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/11/16 17:19:39 UTC
[GitHub] [tomcat] sdeleuze opened a new pull request, #569: Refine native resources metadata
sdeleuze opened a new pull request, #569:
URL: https://github.com/apache/tomcat/pull/569
This commit updates the native resources hints in order to avoid classpath wide inclusion of resources.
@markt-asf @mhalbritter Please check I did not make any mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] sdeleuze commented on a diff in pull request #569: Refine native resources metadata
Posted by GitBox <gi...@apache.org>.
sdeleuze commented on code in PR #569:
URL: https://github.com/apache/tomcat/pull/569#discussion_r1024921333
##########
modules/stuffed/tomcat-resource.json:
##########
@@ -73,9 +73,13 @@
{"name":"org.apache.tomcat.websocket.server.LocalStrings"}
],
"resources":[
- {"pattern":".*/mbeans-descriptors.xml$"},
- {"pattern":".*/*.properties$"},
- {"pattern":".*/*.dtd$"},
- {"pattern":".*/*.xsd$"}
+ {"pattern":"^org/apache/tomcat/.*mbeans-descriptors\\.xml$"},
+ {"pattern":"^org/apache/catalina/.*mbeans-descriptors\\.xml$"},
+ {"pattern":"^org/apache/coyote/.*mbeans-descriptors\\.xml$"},
+ {"pattern":"^org/apache/catalina/.*\\.properties$"},
+ {"pattern":"^jakarta/servlet/resources/.*"},
Review Comment:
I am not sure, if for typical use case we could keep only the latest version for example, would be nice, but I would need Tomcat team guidelines for that cc @markt-asf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] sdeleuze commented on a diff in pull request #569: Refine native resources metadata
Posted by GitBox <gi...@apache.org>.
sdeleuze commented on code in PR #569:
URL: https://github.com/apache/tomcat/pull/569#discussion_r1025160017
##########
modules/stuffed/tomcat-resource.json:
##########
@@ -73,9 +73,13 @@
{"name":"org.apache.tomcat.websocket.server.LocalStrings"}
],
"resources":[
- {"pattern":".*/mbeans-descriptors.xml$"},
- {"pattern":".*/*.properties$"},
- {"pattern":".*/*.dtd$"},
- {"pattern":".*/*.xsd$"}
+ {"pattern":"^org/apache/tomcat/.*mbeans-descriptors\\.xml$"},
+ {"pattern":"^org/apache/catalina/.*mbeans-descriptors\\.xml$"},
+ {"pattern":"^org/apache/coyote/.*mbeans-descriptors\\.xml$"},
+ {"pattern":"^org/apache/catalina/.*\\.properties$"},
+ {"pattern":"^jakarta/servlet/resources/.*"},
Review Comment:
Interesting, let me have another look to see if this should be shipped by default or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] sdeleuze commented on a diff in pull request #569: Refine native resources metadata
Posted by GitBox <gi...@apache.org>.
sdeleuze commented on code in PR #569:
URL: https://github.com/apache/tomcat/pull/569#discussion_r1024337553
##########
modules/stuffed/tomcat-resource.json:
##########
@@ -73,9 +73,13 @@
{"name":"org.apache.tomcat.websocket.server.LocalStrings"}
],
"resources":[
- {"pattern":".*/mbeans-descriptors.xml$"},
- {"pattern":".*/*.properties$"},
- {"pattern":".*/*.dtd$"},
- {"pattern":".*/*.xsd$"}
Review Comment:
They are now included via `{"pattern":"^jakarta/servlet/resources/.*"}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] mhalbritter commented on a diff in pull request #569: Refine native resources metadata
Posted by GitBox <gi...@apache.org>.
mhalbritter commented on code in PR #569:
URL: https://github.com/apache/tomcat/pull/569#discussion_r1024913815
##########
modules/stuffed/tomcat-resource.json:
##########
@@ -73,9 +73,13 @@
{"name":"org.apache.tomcat.websocket.server.LocalStrings"}
],
"resources":[
- {"pattern":".*/mbeans-descriptors.xml$"},
- {"pattern":".*/*.properties$"},
- {"pattern":".*/*.dtd$"},
- {"pattern":".*/*.xsd$"}
+ {"pattern":"^org/apache/tomcat/.*mbeans-descriptors\\.xml$"},
+ {"pattern":"^org/apache/catalina/.*mbeans-descriptors\\.xml$"},
+ {"pattern":"^org/apache/coyote/.*mbeans-descriptors\\.xml$"},
+ {"pattern":"^org/apache/catalina/.*\\.properties$"},
+ {"pattern":"^jakarta/servlet/resources/.*"},
Review Comment:
So we really need to include all of the XSDs and the DTDs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] ChristopherSchultz commented on a diff in pull request #569: Refine native resources metadata
Posted by GitBox <gi...@apache.org>.
ChristopherSchultz commented on code in PR #569:
URL: https://github.com/apache/tomcat/pull/569#discussion_r1024327589
##########
modules/stuffed/tomcat-resource.json:
##########
@@ -73,9 +73,13 @@
{"name":"org.apache.tomcat.websocket.server.LocalStrings"}
],
"resources":[
- {"pattern":".*/mbeans-descriptors.xml$"},
- {"pattern":".*/*.properties$"},
- {"pattern":".*/*.dtd$"},
- {"pattern":".*/*.xsd$"}
Review Comment:
Is a pattern no longer (or was never?) necessary for `.xsd`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] sdeleuze commented on a diff in pull request #569: Refine native resources metadata
Posted by GitBox <gi...@apache.org>.
sdeleuze commented on code in PR #569:
URL: https://github.com/apache/tomcat/pull/569#discussion_r1025340076
##########
modules/stuffed/tomcat-resource.json:
##########
@@ -73,9 +73,13 @@
{"name":"org.apache.tomcat.websocket.server.LocalStrings"}
],
"resources":[
- {"pattern":".*/mbeans-descriptors.xml$"},
- {"pattern":".*/*.properties$"},
- {"pattern":".*/*.dtd$"},
- {"pattern":".*/*.xsd$"}
+ {"pattern":"^org/apache/tomcat/.*mbeans-descriptors\\.xml$"},
+ {"pattern":"^org/apache/catalina/.*mbeans-descriptors\\.xml$"},
+ {"pattern":"^org/apache/coyote/.*mbeans-descriptors\\.xml$"},
+ {"pattern":"^org/apache/catalina/.*\\.properties$"},
+ {"pattern":"^jakarta/servlet/resources/.*"},
Review Comment:
After a deeper look, I have chosen to remove `jakarta/servlet/resources/*` resources from the default configuration of `tomcat-embed-core`, since those optional resources weight `1.5M`! Users leveraging them will just have to configure something like `{"pattern":"^jakarta/servlet/resources/.*"}`, not that different from what people need to do for JNI or extra reflection configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf merged pull request #569: Refine native resources metadata
Posted by GitBox <gi...@apache.org>.
markt-asf merged PR #569:
URL: https://github.com/apache/tomcat/pull/569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org