You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/12/09 10:05:04 UTC
[GitHub] [incubator-celeborn] zeropc opened a new pull request, #1061: add heartbeat and write timeout for transport clients
zeropc opened a new pull request, #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061
# add heartbeat and write timeout for transport clients
### What changes were proposed in this pull request?
- Add optional heartbeat for idle connections in the client pool
- Add optional write timeout timer for data clients (which already exists in rpc clients)
### Why are the changes needed?
Changes are mainly made in the channel pipelines which are inited in TransportContext#initializePipeline
### What are the items that need reviewer attention?
### Related issues.
### Related pull requests.
### How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on PR #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061#issuecomment-1344203811
Plz run ./dev/reformat to automatically fix style issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zeropc commented on pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
zeropc commented on PR #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061#issuecomment-1345107631
adding heartbeat seems to be a bad idea here. it should never be applied in global scope. especially for channels that use file region to transfer data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061#issuecomment-1344115457
Pls create an jira ticket and use it in pr title `[CELEBORN-xx] xxxx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zeropc commented on a diff in pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
zeropc commented on code in PR #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061#discussion_r1044978262
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java:
##########
@@ -162,6 +169,9 @@ public TransportClient createClient(String remoteHost, int remotePort, int parti
if (cachedClient.isActive()) {
logger.trace("Returning cached connection to {}: {}", resolvedAddress, cachedClient);
return cachedClient;
+ } else if (cachedClient.getChannel().isActive()) {
+ logger.info("Found timeout connection to {}, creating a new one.", cachedClient.getSocketAddress());
+ danglingChannels.add(cachedClient.getChannel());
Review Comment:
danglingChannels is added to make it backward compatible. otherwise, if channel is directly closed for heartbeat timeout, inflight request that takes time longer than heartbeat interval * wait times may be closed.
in short, it may conflict with the original io.connectionTimeout config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061#discussion_r1044305376
##########
common/src/main/java/org/apache/celeborn/common/network/util/TransportConf.java:
##########
@@ -55,6 +55,18 @@ public int connectionTimeoutMs() {
return conf.networkIoConnectionTimeoutMs(module);
}
+ /** Connection heartbeat timeout in milliseconds. Default 0 secs (never). */
+ public int heartbeatTimeoutMs() {
+ return (int) JavaUtils.timeStringAsSec(
+ conf.get("rss.network.heartbeat.timeout", "0s")) * 1000;
Review Comment:
`celeborn.network.heartbeat.timeout`?
I think you need to make it the same as `networkIoConnectionTimeoutMs`
##########
common/src/main/java/org/apache/celeborn/common/network/util/TransportConf.java:
##########
@@ -55,6 +55,18 @@ public int connectionTimeoutMs() {
return conf.networkIoConnectionTimeoutMs(module);
}
+ /** Connection heartbeat timeout in milliseconds. Default 0 secs (never). */
+ public int heartbeatTimeoutMs() {
+ return (int) JavaUtils.timeStringAsSec(
+ conf.get("rss.network.heartbeat.timeout", "0s")) * 1000;
+ }
+
+ /** Channel write timeout in milliseconds. Default 0 secs (never). */
+ public int writeTimeoutMs() {
+ return (int) JavaUtils.timeStringAsSec(
+ conf.get("rss.network.write.timeout", "0s")) * 1000;
Review Comment:
ditto
##########
common/src/main/java/org/apache/celeborn/common/network/protocol/Message.java:
##########
@@ -84,7 +84,9 @@ public enum Type implements Encodable {
PUSH_MERGED_DATA(12),
REGION_START(13),
REGION_FINISH(14),
- PUSH_DATA_HAND_SHAKE(15);
+ PUSH_DATA_HAND_SHAKE(15),
+ Ping(16),
+ Pong(17);
Review Comment:
Use upper case?
```
PING(16),
PONG(17);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061#issuecomment-1344127914
If two thing, I prefer you can do these in separated pr
```
Add optional heartbeat for idle connections in the client pool
Add optional write timeout timer for data clients (which already exists in rpc clients)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zeropc commented on a diff in pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
zeropc commented on code in PR #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061#discussion_r1044990525
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java:
##########
@@ -162,6 +169,9 @@ public TransportClient createClient(String remoteHost, int remotePort, int parti
if (cachedClient.isActive()) {
logger.trace("Returning cached connection to {}: {}", resolvedAddress, cachedClient);
return cachedClient;
+ } else if (cachedClient.getChannel().isActive()) {
+ logger.info("Found timeout connection to {}, creating a new one.", cachedClient.getSocketAddress());
+ danglingChannels.add(cachedClient.getChannel());
Review Comment:
alse it wont grow infinitely, as io.connectionTimeout config will close idle connections at last
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on code in PR #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061#discussion_r1044960873
##########
common/src/main/java/org/apache/celeborn/common/network/util/TransportConf.java:
##########
@@ -55,6 +55,18 @@ public int connectionTimeoutMs() {
return conf.networkIoConnectionTimeoutMs(module);
}
+ /** Connection heartbeat timeout in milliseconds. Default 0 secs (never). */
+ public int heartbeatTimeoutMs() {
+ return (int) JavaUtils.timeStringAsSec(
+ conf.get("rss.network.heartbeat.timeout", "0s")) * 1000;
Review Comment:
I don't think we should make the default value to 0. According to getDanglingPingThreshold
```
private int getDanglingPingThreshold() {
int heartbeatTimeout = conf.heartbeatTimeoutMs() / 1000;
int q = heartbeatTimeout / ALL_IDLE_TIMEOUT;
int m = heartbeatTimeout % ALL_IDLE_TIMEOUT;
return m == 0 ? q : q + 1;
}
```
if default to zero, then threshold will be 1, which means one heartbeat timeout(5s) will cause the client timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zeropc commented on pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
zeropc commented on PR #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061#issuecomment-1345102602
it seems that adding global heartbeat for
> If two thing, I prefer you can do these in separated pr
>
> ```
> Add optional heartbeat for idle connections in the client pool
> Add optional write timeout timer for data clients (which already exists in rpc clients)
> ```
it should be so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zeropc commented on a diff in pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
zeropc commented on code in PR #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061#discussion_r1044990525
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java:
##########
@@ -162,6 +169,9 @@ public TransportClient createClient(String remoteHost, int remotePort, int parti
if (cachedClient.isActive()) {
logger.trace("Returning cached connection to {}: {}", resolvedAddress, cachedClient);
return cachedClient;
+ } else if (cachedClient.getChannel().isActive()) {
+ logger.info("Found timeout connection to {}, creating a new one.", cachedClient.getSocketAddress());
+ danglingChannels.add(cachedClient.getChannel());
Review Comment:
Also, the io.connectionTimeout feature will close idle connections at last, and related channels in danglingChannels will be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061#issuecomment-1344131174
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1061?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1061](https://codecov.io/gh/apache/incubator-celeborn/pull/1061?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af113fa) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/84d67d019dff73580bd14aa489ce939e2f1fc58c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84d67d0) will **increase** coverage by `0.02%`.
> The diff coverage is `30.30%`.
```diff
@@ Coverage Diff @@
## main #1061 +/- ##
============================================
+ Coverage 25.26% 25.29% +0.02%
- Complexity 772 779 +7
============================================
Files 212 214 +2
Lines 18027 18089 +62
Branches 2036 2044 +8
============================================
+ Hits 4555 4575 +20
- Misses 13162 13202 +40
- Partials 310 312 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1061?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/celeborn/common/network/protocol/Ping.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9wcm90b2NvbC9QaW5nLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/celeborn/common/network/protocol/Pong.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9wcm90b2NvbC9Qb25nLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...common/network/server/TransportChannelHandler.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zZXJ2ZXIvVHJhbnNwb3J0Q2hhbm5lbEhhbmRsZXIuamF2YQ==) | `63.15% <30.00%> (-12.29%)` | :arrow_down: |
| [...ache/celeborn/common/network/protocol/Message.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9wcm90b2NvbC9NZXNzYWdlLmphdmE=) | `51.19% <42.85%> (-1.38%)` | :arrow_down: |
| [.../common/network/client/TransportClientFactory.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9jbGllbnQvVHJhbnNwb3J0Q2xpZW50RmFjdG9yeS5qYXZh) | `83.80% <50.00%> (-2.05%)` | :arrow_down: |
| [...ache/celeborn/common/network/TransportContext.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9UcmFuc3BvcnRDb250ZXh0LmphdmE=) | `78.04% <57.14%> (-5.29%)` | :arrow_down: |
| [...he/celeborn/common/network/util/TransportConf.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay91dGlsL1RyYW5zcG9ydENvbmYuamF2YQ==) | `84.61% <100.00%> (+2.79%)` | :arrow_up: |
| [...ice/deploy/master/clustermeta/ha/HARaftServer.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvY2x1c3Rlcm1ldGEvaGEvSEFSYWZ0U2VydmVyLmphdmE=) | `76.57% <0.00%> (-1.36%)` | :arrow_down: |
| [...apache/celeborn/common/network/util/JavaUtils.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay91dGlsL0phdmFVdGlscy5qYXZh) | `38.02% <0.00%> (+0.70%)` | :arrow_up: |
| [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `71.72% <0.00%> (+2.45%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on code in PR #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061#discussion_r1044959141
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java:
##########
@@ -162,6 +169,9 @@ public TransportClient createClient(String remoteHost, int remotePort, int parti
if (cachedClient.isActive()) {
logger.trace("Returning cached connection to {}: {}", resolvedAddress, cachedClient);
return cachedClient;
+ } else if (cachedClient.getChannel().isActive()) {
+ logger.info("Found timeout connection to {}, creating a new one.", cachedClient.getSocketAddress());
+ danglingChannels.add(cachedClient.getChannel());
Review Comment:
Seems danglingChannels will only be cleared in close() which is possibly never called, so danglingChannels may grow infinitely. Do we really need it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zeropc closed pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
zeropc closed pull request #1061: add heartbeat and write timeout for transport clients
URL: https://github.com/apache/incubator-celeborn/pull/1061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zeropc commented on a diff in pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
zeropc commented on code in PR #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061#discussion_r1044990400
##########
common/src/main/java/org/apache/celeborn/common/network/util/TransportConf.java:
##########
@@ -55,6 +55,18 @@ public int connectionTimeoutMs() {
return conf.networkIoConnectionTimeoutMs(module);
}
+ /** Connection heartbeat timeout in milliseconds. Default 0 secs (never). */
+ public int heartbeatTimeoutMs() {
+ return (int) JavaUtils.timeStringAsSec(
+ conf.get("rss.network.heartbeat.timeout", "0s")) * 1000;
Review Comment:
heartbeatTimeout=0
q=0
m=0
it is supposed to return 0, is there something wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1061: add heartbeat and write timeout for transport clients
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on code in PR #1061:
URL: https://github.com/apache/incubator-celeborn/pull/1061#discussion_r1044960873
##########
common/src/main/java/org/apache/celeborn/common/network/util/TransportConf.java:
##########
@@ -55,6 +55,18 @@ public int connectionTimeoutMs() {
return conf.networkIoConnectionTimeoutMs(module);
}
+ /** Connection heartbeat timeout in milliseconds. Default 0 secs (never). */
+ public int heartbeatTimeoutMs() {
+ return (int) JavaUtils.timeStringAsSec(
+ conf.get("rss.network.heartbeat.timeout", "0s")) * 1000;
Review Comment:
I don't think we should make the default value to 0. According to getDanglingPingThreshold
```
private int getDanglingPingThreshold() {
int heartbeatTimeout = conf.heartbeatTimeoutMs() / 1000;
int q = heartbeatTimeout / ALL_IDLE_TIMEOUT;
int m = heartbeatTimeout % ALL_IDLE_TIMEOUT;
return m == 0 ? q : q + 1;
}
```
if default to zero, then threshold will be 1, which means one heartbeat timeout(5s) will cause the client timeout. Maybe default to 30s or so is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org