[GitHub] [trafficserver] ywkaras commented on a change in pull request #8626: Fix 32bit build failure on Odroid Xu-4

[GitBox <gi...@apache.org>]

ywkaras commented on a change in pull request #8626:
URL: https://github.com/apache/trafficserver/pull/8626#discussion_r789859145



##########
File path: proxy/logging/LogUtils.cc
##########
@@ -599,7 +599,7 @@ LogUtils::file_is_writeable(const char *full_filename, off_t *size_bytes, bool *
     if (e < 0) {
       ret_val = -1;
     } else {
-      if (limit_data.rlim_cur != static_cast<rlim_t> RLIM_INFINITY) {
+      if (limit_data.rlim_cur != static_cast<rlim_t>(RLIM_INFINITY)) {

Review comment:
       Thanks, this is good code cleanup in general.  I think the only reason it hasn't broken for x86 build is that RLIM_INFINITY is implemented as macro with parentheses enclosing the value:
   ```
   # define RLIM_INFINITY ((__rlim_t) -1)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org