You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/25 16:49:50 UTC

[GitHub] [airflow] wolfier opened a new issue #16061: Consider and add common sensitive names

wolfier opened a new issue #16061:
URL: https://github.com/apache/airflow/issues/16061


   **Description** 
   
   Since sensitive informations in the connection object (specifically the extras field) are now being masked based on sensitive key names, we should consider adding some common sensitive key names.
   
   `private_key` from [ssh connection](https://airflow.apache.org/docs/apache-airflow-providers-ssh/stable/connections/ssh.html) is an examples.
   
   **Use case / motivation**
   
   Extras field used to be blocked out entirely before the sensitive value masking feature (#15599).
   
   [Before in 2.0.2](https://github.com/apache/airflow/blob/2.0.2/airflow/hooks/base.py#L78
   ) and [after in 2.1.0](https://github.com/apache/airflow/blob/2.1.0/airflow/hooks/base.py#L78
   ).
   
   Extras field containing sensitive information now shown unless the key contains sensitive names.
   
   **Are you willing to submit a PR?** 
   
   @ashb has expressed interest in adding this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb closed issue #16061: Consider and add common sensitive names

Posted by GitBox <gi...@apache.org>.
ashb closed issue #16061:
URL: https://github.com/apache/airflow/issues/16061


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org