You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2015/11/05 19:15:30 UTC
Review Request 39981: GEODE-77: bug fixes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39981/
-----------------------------------------------------------

Review request for geode, anilkumar gingade, Jason Huynh, Jianxia Chen, and Lynn Gallinat.


Repository: geode


Description
-------

GEODE-77: bug fixes

GMSHealthMonitorJUnitTest was incorrectly using Mockito's any() when it should have used isA().  Fixing this exposed a lot of problems in the health monitor that this checkin addresses.  I've also renamed a number of entities so that we now have more uniform use of the term "heartbeat" instead of "check".

This change-set also turns off the JGroups thread pools because they were found to be causing our performance problem.  This exposed a bug in JGroups that they are fixing, but for now there is a workaround in StatRecorder.  Along with the removal of thread pools we now need to pass messages through handleOrDeferMessage() in GMSMembershipManager since processMessage() can be blocked during initialization, causing a new process to time out trying to join the distributed system.

GMSJoinLeave was not setting the failure detection ports on a new view if it abandoned a view that it could not prepare.


Diffs
-----

  gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java 4383f1f82f70a844e6718f1f2eb3dbf25eba7063 
  gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSUtil.java e1041f26cc1b87be57255aafc5e6df26c7d96900 
  gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/Services.java 8ab0bbd05624495d9fdb3e6838166ef0e0c50f89 
  gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java 3f5db38d72243e2493df9610dc830cfa750592a4 
  gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 0b2abe3165d05d8d84acdbded2ca988374120934 
  gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/HeartbeatMessage.java b6f37353f256a7173771c701d6fa47433f324030 
  gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/HeartbeatRequestMessage.java 75f6b6e29ac77d31391b216f32105642fa8ce6dd 
  gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/InstallViewMessage.java a5be893647b60a4d7e2474ca17bfc108c1f26ccd 
  gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/SuspectRequest.java a553d39b359bead4563e455d74a0957f5d19712c 
  gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java bd21629b390f261d47be5bdb7e62bc421c2be43d 
  gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/StatRecorder.java 7431fe74c791a253e681f28c92401c7423a2a4f9 
  gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java 204cc0bdbedbe326a1a5187ce79bba22b6e61846 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java 4625a3579a182f41812ad33ee00781727a1cd700 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java 1da7038a7702da5e2b2ad52ec1d83af8a48b1b0c 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/Version.java e58dce8dba09c65a515b9d9948b61017242143dd 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CreateRegionProcessor.java e90f27b4d81f85bf015011a5744849bc46bce096 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/HandShake.java 0b00e31a4d20a8cec3d6e35b104face312665e66 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java 9f079fa30f611b4b1728ec941ff7f69e58ded70f 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/util/PluckStacks.java d599bc9e6002d365c48f9af74cda58329d97dc30 
  gemfire-core/src/main/resources/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/jgroups-config.xml 8393d31d6e936c950726312e51a3f6b05de5f94b 
  gemfire-core/src/main/resources/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/jgroups-mcast.xml c16fad3ae60bd1d7a8dd15c4396e37a85548feb2 
  gemfire-core/src/test/java/com/gemstone/gemfire/cache30/ReconnectDUnitTest.java 26e85869f920fdc6044c059709012e3a9056dfab 
  gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java 8dee00aea92ff66206b2ee28e2b61261d6f4e269 
  gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/fd/GMSHealthMonitorJUnitTest.java cf958178970b8a4950f8951422b39eb9ce03d387 
  gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java dfd77798c91e8f8a74f7c677aa960012817609fa 

Diff: https://reviews.apache.org/r/39981/diff/


Testing
-------

precheckin, integration tests (UDP unicast & multicast, wellness)


Thanks,

Bruce Schuchardt