[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5310: [BYOC] Enhance partitioning and external codegen

[GitBox <gi...@apache.org>]

comaniac commented on a change in pull request #5310: [BYOC] Enhance partitioning and external codegen
URL: https://github.com/apache/incubator-tvm/pull/5310#discussion_r407125613
 
 

 ##########
 File path: src/relay/backend/contrib/codegen_c/codegen.cc
 ##########
 @@ -40,35 +40,44 @@ using namespace backend;
  * purpose. Only several binary options are covered. Users
  * may need to extend them to cover more operators.
  */
-class CodegenC : public ExprVisitor, public CodegenCBase {
+class CodegenC : public relay::ExprFunctor<std::vector<Output>(const Expr&)>,
 
 Review comment:
   I'm debating if we really need to return a vector instead of a single output, because we always return a single value even for tuple nodes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services