You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/08 16:11:57 UTC
[GitHub] [airflow] chenglongyan opened a new pull request, #24333: Migrate Google calendar example DAG to new design AIP-47
chenglongyan opened a new pull request, #24333:
URL: https://github.com/apache/airflow/pull/24333
related: #22447
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24333: Migrate Google calendar example DAG to new design AIP-47
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24333:
URL: https://github.com/apache/airflow/pull/24333#issuecomment-1153118905
I will merge it and fix in bulk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24333: Migrate Google calendar example DAG to new design AIP-47
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24333:
URL: https://github.com/apache/airflow/pull/24333#issuecomment-1152983136
@chenglongyan -> I have just solved a problem where "[source]" links were missing and there are two things to add to make it works. Once I merge https://github.com/apache/airflow/pull/24386 you will get errors for those missing parts, but maybe you can add them now:
1) `__init__.py` should be added for all folders in path of "tests/system/...../example*.py" so that the packages created are not "implicit" namespace packages
2) `System Tests <_api/tests/system/providers/google/../index>` link needs to be added to index to avoid "missing index in TOC tree"
Not sure if you need to do it (not sure if you create any empty directory here), but I'd recommend to rebase on top of my change and fix all problems - I hope to have my change merged soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24333: Migrate Google calendar example DAG to new design AIP-47
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24333:
URL: https://github.com/apache/airflow/pull/24333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org