[GitHub] [activemq-artemis] madhukar-git commented on a change in pull request #3075: Fixing failures on RamDisk due to Java API Files.getFileStore()

[GitBox <gi...@apache.org>]

madhukar-git commented on a change in pull request #3075: Fixing failures on RamDisk due to Java API Files.getFileStore() 
URL: https://github.com/apache/activemq-artemis/pull/3075#discussion_r406998040
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/files/FileStoreMonitor.java
 ##########
 @@ -73,8 +75,8 @@ public FileStoreMonitor addStore(File file) throws IOException {
             try {
                addStore(Files.getFileStore(file.toPath()));
             } catch (IOException e) {
-               logger.error("Error getting file store for " + file.getAbsolutePath(), e);
-               throw e;
+               logger.warn("Error getting file store for " + file.getAbsolutePath() + ". Trying dummy FileStore", e);
 
 Review comment:
   Thanks for the valuable feedback. We recently upgraded from Wildfly 10 to 17. This patch was intended to fix  our product regressions which run on RAM disk. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services