[GitHub] [openmeetings] solomax commented on a change in pull request #121: OPENMEETINGS-2560 Improve response to return the actual error to client.

[GitBox <gi...@apache.org>]

solomax commented on a change in pull request #121:
URL: https://github.com/apache/openmeetings/pull/121#discussion_r565047843



##########
File path: openmeetings-webservice/src/main/java/org/apache/openmeetings/webservice/UserWebService.java
##########
@@ -156,7 +156,7 @@ public UserDTO add(
 			@WebParam(name="sid") @QueryParam("sid") String sid
 			, @WebParam(name="user") @FormParam("user") UserDTO user
 			, @WebParam(name="confirm") @FormParam("confirm") Boolean confirm
-			)
+			) throws ServiceException

Review comment:
       This one is unnecessary (and will produce Sonar error)
   `ServiceException extends RuntimeException` so it shouldn't be explicitly declared

##########
File path: openmeetings-webservice/src/main/java/org/apache/openmeetings/webservice/UserWebService.java
##########
@@ -294,7 +294,7 @@ public ServiceResult getRoomHash(
 			@WebParam(name="sid") @QueryParam("sid") String sid
 			, @WebParam(name="user") @FormParam("user") ExternalUserDTO user
 			, @WebParam(name="options") @FormParam("options") RoomOptionsDTO options
-			)

Review comment:
       same here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org