[GitHub] spark pull request: [SPARK-6027][SPARK-5546] Fixed --jar and --pac...

[tdas <gi...@git.apache.org>]

Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4779#discussion_r25465873
  
    --- Diff: external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaUtils.scala ---
    @@ -532,3 +532,31 @@ object KafkaUtils {
         )
       }
     }
    +
    +/**
    + * This is a helper class that wraps the KafkaUtils.createStream() into more
    + * Python-friendly class and function so that it can be easily
    + * instantiated and called from Python's KafkaUtils (see SPARK-6027).
    + *
    + * The zero-arg constructor helps instantiate this class from the Class object
    + * classOf[KafkaUtilsPythonHelper].newInstance(), and the createStream()
    + * takes care of known parameters instead of passing them from Python
    + */
    +private[kafka]
    --- End diff --
    
    I am not sure if I will be able to call from python if this is strictly private. I havent tested it though. I dont think that;s a big deal, as long as its hidden from public view


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org