You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/25 02:27:26 UTC

[GitHub] [pulsar] rdhabalia commented on a change in pull request #11743: [pulsar-client] Fix: set and return topic name on message api

rdhabalia commented on a change in pull request #11743:
URL: https://github.com/apache/pulsar/pull/11743#discussion_r695343483



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
##########
@@ -78,13 +78,14 @@
     private boolean poolMessage;
     
     // Constructor for out-going message
-    public static <T> MessageImpl<T> create(MessageMetadata msgMetadata, ByteBuffer payload, Schema<T> schema) {

Review comment:
       `MessageImpl` is implementation class and it should not be used as a contract.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org