You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/05 21:48:38 UTC

[GitHub] [arrow-datafusion] ozankabak commented on pull request #3705: Remove type coercions from ScalarValue and aggregation function code

ozankabak commented on PR #3705:
URL: https://github.com/apache/arrow-datafusion/pull/3705#issuecomment-1269015625

   Yes, I did a bunch of drive-by cleanups while removing coercions :) The example you posted works because coercions are already done before we ever call `add_to_row`. My first thoughts regarding overflow were similar to yours, but then I realized by the time we perform additions we already have everything casted to wider types -- so the coercions I removed really seemed unnecessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org