You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2016/10/18 21:21:44 UTC
Review Request 52995: Error Catalog enhancement
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha GS, and Suma Shivaprasad.
Bugs: ATLAS-1200
https://issues.apache.org/jira/browse/ATLAS-1200
Repository: atlas
Description
-------
Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
Diffs
-----
common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
intg/src/main/resources/errorMessages.properties PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 78cbd635ba8d5ac2c1ae5144fec685f102dfc66e
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java f36c0d681ccff1c77fe0a35a1049e8cd54577fae
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 67ff1a0d842186e202ba14c3ba2a47193cbb7e2b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java ea1b03b661f265abcdb11cc1d9827d6196475638
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 4b50aacbc57a8ebd9b25febff3fc044082d4009a
webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 889c3dd0bf65c8bbfcb520ca6e9b72def07aed5f
webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
Diff: https://reviews.apache.org/r/52995/diff/
Testing
-------
Tested will REST API calls.
Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
Thanks,
Apoorv Naik
Re: Review Request 52995: Error Catalog enhancement
Posted by Suma Shivaprasad <su...@gmail.com>.
> On Oct. 21, 2016, 10:31 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java, line 23
> > <https://reviews.apache.org/r/52995/diff/7/?file=1542874#file1542874line23>
> >
> > all the errors mapped here are client side errors. the server side errors could occur during graph commit during which it is visible only in GraphTransactionInterceptor. We need to map error codes to those as well and set the REST error code to 500 in that case
BackendException is thrown in case of errors
/**
* Commits and closes the transaction.
* <p/>
* Will attempt to persist all modifications which may result in exceptions in case of persistence failures or
* lock contention.
* <br />
* The call releases data structures if possible. All element references (e.g. vertex objects) retrieved
* through this transaction are stale after the transaction closes and should no longer be used.
*
* @throws com.thinkaurelius.titan.diskstorage.BackendException
* if an error arises during persistence
*/
public void commit();
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153609
-----------------------------------------------------------
On Oct. 21, 2016, 5:04 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52995/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2016, 5:04 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1200
> https://issues.apache.org/jira/browse/ATLAS-1200
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
> AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
>
> Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
> webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
>
> Diff: https://reviews.apache.org/r/52995/diff/
>
>
> Testing
> -------
>
> Tested will REST API calls.
> Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 52995: Error Catalog enhancement
Posted by Suma Shivaprasad <su...@gmail.com>.
> On Oct. 21, 2016, 10:31 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java, line 23
> > <https://reviews.apache.org/r/52995/diff/7/?file=1542874#file1542874line23>
> >
> > all the errors mapped here are client side errors. the server side errors could occur during graph commit during which it is visible only in GraphTransactionInterceptor. We need to map error codes to those as well and set the REST error code to 500 in that case
>
> Suma Shivaprasad wrote:
> BackendException is thrown in case of errors
>
> /**
> * Commits and closes the transaction.
> * <p/>
> * Will attempt to persist all modifications which may result in exceptions in case of persistence failures or
> * lock contention.
> * <br />
> * The call releases data structures if possible. All element references (e.g. vertex objects) retrieved
> * through this transaction are stale after the transaction closes and should no longer be used.
> *
> * @throws com.thinkaurelius.titan.diskstorage.BackendException
> * if an error arises during persistence
> */
> public void commit();
>
> Suma Shivaprasad wrote:
> see https://issues.apache.org/jira/browse/ATLAS-503 for more details
>
> Apoorv Naik wrote:
> Should I add a custom mapper for any titan exception ? Convert them to 500s ?
Yes any Titan Exception would map to a 500
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153609
-----------------------------------------------------------
On Oct. 24, 2016, 4:21 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52995/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2016, 4:21 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1200
> https://issues.apache.org/jira/browse/ATLAS-1200
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
> AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
>
> Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> webapp/src/main/java/org/apache/atlas/web/errors/AllExceptionMapper.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
> webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
>
> Diff: https://reviews.apache.org/r/52995/diff/
>
>
> Testing
> -------
>
> Tested will REST API calls.
> Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
> On Oct. 21, 2016, 10:31 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java, line 23
> > <https://reviews.apache.org/r/52995/diff/7/?file=1542874#file1542874line23>
> >
> > all the errors mapped here are client side errors. the server side errors could occur during graph commit during which it is visible only in GraphTransactionInterceptor. We need to map error codes to those as well and set the REST error code to 500 in that case
>
> Suma Shivaprasad wrote:
> BackendException is thrown in case of errors
>
> /**
> * Commits and closes the transaction.
> * <p/>
> * Will attempt to persist all modifications which may result in exceptions in case of persistence failures or
> * lock contention.
> * <br />
> * The call releases data structures if possible. All element references (e.g. vertex objects) retrieved
> * through this transaction are stale after the transaction closes and should no longer be used.
> *
> * @throws com.thinkaurelius.titan.diskstorage.BackendException
> * if an error arises during persistence
> */
> public void commit();
>
> Suma Shivaprasad wrote:
> see https://issues.apache.org/jira/browse/ATLAS-503 for more details
Should I add a custom mapper for any titan exception ? Convert them to 500s ?
- Apoorv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153609
-----------------------------------------------------------
On Oct. 21, 2016, 5:04 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52995/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2016, 5:04 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1200
> https://issues.apache.org/jira/browse/ATLAS-1200
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
> AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
>
> Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
> webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
>
> Diff: https://reviews.apache.org/r/52995/diff/
>
>
> Testing
> -------
>
> Tested will REST API calls.
> Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 52995: Error Catalog enhancement
Posted by Suma Shivaprasad <su...@gmail.com>.
> On Oct. 21, 2016, 10:31 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java, line 23
> > <https://reviews.apache.org/r/52995/diff/7/?file=1542874#file1542874line23>
> >
> > all the errors mapped here are client side errors. the server side errors could occur during graph commit during which it is visible only in GraphTransactionInterceptor. We need to map error codes to those as well and set the REST error code to 500 in that case
>
> Suma Shivaprasad wrote:
> BackendException is thrown in case of errors
>
> /**
> * Commits and closes the transaction.
> * <p/>
> * Will attempt to persist all modifications which may result in exceptions in case of persistence failures or
> * lock contention.
> * <br />
> * The call releases data structures if possible. All element references (e.g. vertex objects) retrieved
> * through this transaction are stale after the transaction closes and should no longer be used.
> *
> * @throws com.thinkaurelius.titan.diskstorage.BackendException
> * if an error arises during persistence
> */
> public void commit();
see https://issues.apache.org/jira/browse/ATLAS-503 for more details
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153609
-----------------------------------------------------------
On Oct. 21, 2016, 5:04 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52995/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2016, 5:04 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1200
> https://issues.apache.org/jira/browse/ATLAS-1200
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
> AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
>
> Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
> webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
>
> Diff: https://reviews.apache.org/r/52995/diff/
>
>
> Testing
> -------
>
> Tested will REST API calls.
> Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 52995: Error Catalog enhancement
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153609
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java (line 23)
<https://reviews.apache.org/r/52995/#comment223016>
all the errors mapped here are client side errors. the server side errors could occur during graph commit during which it is visible only in GraphTransactionInterceptor. We need to map error codes to those as well and set the REST error code to 500 in that case
- Suma Shivaprasad
On Oct. 21, 2016, 5:04 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52995/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2016, 5:04 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1200
> https://issues.apache.org/jira/browse/ATLAS-1200
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
> AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
>
> Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
> webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
>
> Diff: https://reviews.apache.org/r/52995/diff/
>
>
> Testing
> -------
>
> Tested will REST API calls.
> Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 52995: Error Catalog enhancement
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153744
-----------------------------------------------------------
Ship it!
Ship It!
- Suma Shivaprasad
On Oct. 24, 2016, 9:29 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52995/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2016, 9:29 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1200
> https://issues.apache.org/jira/browse/ATLAS-1200
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
> AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
>
> Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> webapp/src/main/java/org/apache/atlas/web/errors/AtlasBaseExceptionMapper.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
> webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
>
> Diff: https://reviews.apache.org/r/52995/diff/
>
>
> Testing
> -------
>
> Tested will REST API calls.
> Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/
-----------------------------------------------------------
(Updated Oct. 24, 2016, 10:14 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
Changes
-------
Rebased with latest changes from Master
Bugs: ATLAS-1200
https://issues.apache.org/jira/browse/ATLAS-1200
Repository: atlas
Description
-------
Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f63
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41
intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a3
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 1aca5eb
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 4bdcf00
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java fd16cbd
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 32ef939
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java d5fb584
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 5e42c13
webapp/src/main/java/org/apache/atlas/web/errors/AllExceptionMapper.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/errors/AtlasBaseExceptionMapper.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java a39dfb0
webapp/src/main/webapp/WEB-INF/web.xml c551814
Diff: https://reviews.apache.org/r/52995/diff/
Testing
-------
Tested will REST API calls.
Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
Thanks,
Apoorv Naik
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/
-----------------------------------------------------------
(Updated Oct. 24, 2016, 9:29 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
Changes
-------
Annotated both Provider classes as Singletons
Bugs: ATLAS-1200
https://issues.apache.org/jira/browse/ATLAS-1200
Repository: atlas
Description
-------
Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
webapp/src/main/java/org/apache/atlas/web/errors/AtlasBaseExceptionMapper.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
Diff: https://reviews.apache.org/r/52995/diff/
Testing
-------
Tested will REST API calls.
Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
Thanks,
Apoorv Naik
Re: Review Request 52995: Error Catalog enhancement
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153733
-----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/errors/AllExceptionMapper.java (line 36)
<https://reviews.apache.org/r/52995/#comment223150>
also add @Singleton
- Suma Shivaprasad
On Oct. 24, 2016, 8:56 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52995/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2016, 8:56 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1200
> https://issues.apache.org/jira/browse/ATLAS-1200
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
> AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
>
> Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> webapp/src/main/java/org/apache/atlas/web/errors/AllExceptionMapper.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
> webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
>
> Diff: https://reviews.apache.org/r/52995/diff/
>
>
> Testing
> -------
>
> Tested will REST API calls.
> Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/
-----------------------------------------------------------
(Updated Oct. 24, 2016, 8:56 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
Changes
-------
Addressed review comments
Bugs: ATLAS-1200
https://issues.apache.org/jira/browse/ATLAS-1200
Repository: atlas
Description
-------
Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
webapp/src/main/java/org/apache/atlas/web/errors/AllExceptionMapper.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
Diff: https://reviews.apache.org/r/52995/diff/
Testing
-------
Tested will REST API calls.
Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
Thanks,
Apoorv Naik
Re: Review Request 52995: Error Catalog enhancement
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153732
-----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/errors/AllExceptionMapper.java (line 36)
<https://reviews.apache.org/r/52995/#comment223149>
should be AllExceptionMapper.class
- Suma Shivaprasad
On Oct. 24, 2016, 4:21 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52995/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2016, 4:21 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1200
> https://issues.apache.org/jira/browse/ATLAS-1200
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
> AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
>
> Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> webapp/src/main/java/org/apache/atlas/web/errors/AllExceptionMapper.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
> webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
>
> Diff: https://reviews.apache.org/r/52995/diff/
>
>
> Testing
> -------
>
> Tested will REST API calls.
> Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/
-----------------------------------------------------------
(Updated Oct. 24, 2016, 4:21 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
Changes
-------
1. Added AllExceptionMapper for capturing any exception any translating it to a 500 ISE
2. Renamed LoggingExceptionMapper to AtlasBaseExceptionMapper
3. NO_SEARCH_RESULTS status code changed to 204 instead of 404
Bugs: ATLAS-1200
https://issues.apache.org/jira/browse/ATLAS-1200
Repository: atlas
Description
-------
Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
webapp/src/main/java/org/apache/atlas/web/errors/AllExceptionMapper.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
Diff: https://reviews.apache.org/r/52995/diff/
Testing
-------
Tested will REST API calls.
Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
Thanks,
Apoorv Naik
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/
-----------------------------------------------------------
(Updated Oct. 21, 2016, 5:04 a.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
Changes
-------
Removed typeRegistry injection
Bugs: ATLAS-1200
https://issues.apache.org/jira/browse/ATLAS-1200
Repository: atlas
Description
-------
Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
Diff: https://reviews.apache.org/r/52995/diff/
Testing
-------
Tested will REST API calls.
Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
Thanks,
Apoorv Naik
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
> On Oct. 21, 2016, 3:11 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java, line 201
> > <https://reviews.apache.org/r/52995/diff/6/?file=1542856#file1542856line201>
> >
> > empty search result does not look like an error condition. Consider returning an empty list (i.e. not null). Please review other search*() methods as well.
The idea was to distinguish the success response (200 OK) from a empty search result (204 No Content), hence the exception. Should I still get rid of it ?
- Apoorv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153493
-----------------------------------------------------------
On Oct. 21, 2016, 2:50 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52995/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2016, 2:50 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1200
> https://issues.apache.org/jira/browse/ATLAS-1200
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
> AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
>
> Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
> webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
>
> Diff: https://reviews.apache.org/r/52995/diff/
>
>
> Testing
> -------
>
> Tested will REST API calls.
> Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
> On Oct. 21, 2016, 3:11 a.m., Madhan Neethiraj wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java, line 67
> > <https://reviews.apache.org/r/52995/diff/6/?file=1542863#file1542863line67>
> >
> > atlasTypeRegistry does not seem to be used/needed here. Please review.
Don't know why this showed up as my change. Will clean up.
- Apoorv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153493
-----------------------------------------------------------
On Oct. 21, 2016, 2:50 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52995/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2016, 2:50 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1200
> https://issues.apache.org/jira/browse/ATLAS-1200
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
> AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
>
> Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
> webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
>
> Diff: https://reviews.apache.org/r/52995/diff/
>
>
> Testing
> -------
>
> Tested will REST API calls.
> Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 52995: Error Catalog enhancement
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153493
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java (line 200)
<https://reviews.apache.org/r/52995/#comment222863>
empty search result does not look like an error condition. Consider returning an empty list (i.e. not null). Please review other search*() methods as well.
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java (line 67)
<https://reviews.apache.org/r/52995/#comment222862>
atlasTypeRegistry does not seem to be used/needed here. Please review.
- Madhan Neethiraj
On Oct. 21, 2016, 2:50 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52995/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2016, 2:50 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1200
> https://issues.apache.org/jira/browse/ATLAS-1200
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
> AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
>
> Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
> webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
>
> Diff: https://reviews.apache.org/r/52995/diff/
>
>
> Testing
> -------
>
> Tested will REST API calls.
> Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/
-----------------------------------------------------------
(Updated Oct. 21, 2016, 2:50 a.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
Changes
-------
1. Addressed comments regarding the getAll\*Defs returning empty list
2. Using existing utility function to produce Json
Bugs: ATLAS-1200
https://issues.apache.org/jira/browse/ATLAS-1200
Repository: atlas
Description
-------
Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
Diff: https://reviews.apache.org/r/52995/diff/
Testing
-------
Tested will REST API calls.
Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
Thanks,
Apoorv Naik
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
> On Oct. 21, 2016, 2:27 a.m., Madhan Neethiraj wrote:
> > webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java, line 42
> > <https://reviews.apache.org/r/52995/diff/5/?file=1542438#file1542438line42>
> >
> > Instead of replacing generic type E with AtlasBaseException, it might be better to handle AtlasBaseException type of exception inside toResponse(E excp) - similar to how WebApplicationException is handled.
> >
> > Woud that make this mapper to handle more type of exceptions? Please review.
This ExceptionMapper was never used for some reason, hence I specialized if for AtlasBaseException. Can definitely be made generic to capture and translate more exceptions.
> On Oct. 21, 2016, 2:27 a.m., Madhan Neethiraj wrote:
> > webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java, line 60
> > <https://reviews.apache.org/r/52995/diff/5/?file=1542438#file1542438line60>
> >
> > Consider replacing this with AtlasType.toJson(errorJsonMap)
Will do.
- Apoorv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153487
-----------------------------------------------------------
On Oct. 20, 2016, 5:29 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52995/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 5:29 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1200
> https://issues.apache.org/jira/browse/ATLAS-1200
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
> AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
>
> Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
> webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
>
> Diff: https://reviews.apache.org/r/52995/diff/
>
>
> Testing
> -------
>
> Tested will REST API calls.
> Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
> On Oct. 21, 2016, 2:27 a.m., Madhan Neethiraj wrote:
> > webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java, line 42
> > <https://reviews.apache.org/r/52995/diff/5/?file=1542438#file1542438line42>
> >
> > Instead of replacing generic type E with AtlasBaseException, it might be better to handle AtlasBaseException type of exception inside toResponse(E excp) - similar to how WebApplicationException is handled.
> >
> > Woud that make this mapper to handle more type of exceptions? Please review.
>
> Apoorv Naik wrote:
> This ExceptionMapper was never used for some reason, hence I specialized if for AtlasBaseException. Can definitely be made generic to capture and translate more exceptions.
Ok so I made it generic but the Jersey system doesn't like for some reason and starts throwing NPEs causing the server startup to fail. Let's keep the exception mapper specifically for AtlasBaseException now and later we can make it more versatile.
```
java.lang.NullPointerException
at java.lang.Class.isAssignableFrom(Native Method)
at com.sun.jersey.server.impl.application.ExceptionMapperFactory.getExceptionType(ExceptionMapperFactory.java:115)
at com.sun.jersey.server.impl.application.ExceptionMapperFactory.init(ExceptionMapperFactory.java:75)
at com.sun.jersey.server.impl.application.WebApplicationImpl._initiate(WebApplicationImpl.java:1335)
at com.sun.jersey.server.impl.application.WebApplicationImpl.access$700(WebApplicationImpl.java:180)
at com.sun.jersey.server.impl.application.WebApplicationImpl$13.f(WebApplicationImpl.java:799)
at com.sun.jersey.server.impl.application.WebApplicationImpl$13.f(WebApplicationImpl.java:795)
at com.sun.jersey.spi.inject.Errors.processWithErrors(Errors.java:193)
at com.sun.jersey.server.impl.application.WebApplicationImpl.initiate(WebApplicationImpl.java:795)
at com.sun.jersey.guice.spi.container.servlet.GuiceContainer.initiate(GuiceContainer.java:121)
at com.sun.jersey.spi.container.servlet.ServletContainer$InternalWebComponent.initiate(ServletContainer.java:339)
at com.sun.jersey.spi.container.servlet.WebComponent.load(WebComponent.java:605)
```
- Apoorv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153487
-----------------------------------------------------------
On Oct. 21, 2016, 5:04 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52995/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2016, 5:04 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1200
> https://issues.apache.org/jira/browse/ATLAS-1200
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
> AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
>
> Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
> webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
>
> Diff: https://reviews.apache.org/r/52995/diff/
>
>
> Testing
> -------
>
> Tested will REST API calls.
> Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 52995: Error Catalog enhancement
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/#review153487
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java (line 120)
<https://reviews.apache.org/r/52995/#comment222849>
Not finding any enum does not seem to be an error condition. Consider returning an empty list instead (i.e. not null).
Please review other such getAll*() and search*() methods as well.
webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java (line 42)
<https://reviews.apache.org/r/52995/#comment222852>
Instead of replacing generic type E with AtlasBaseException, it might be better to handle AtlasBaseException type of exception inside toResponse(E excp) - similar to how WebApplicationException is handled.
Woud that make this mapper to handle more type of exceptions? Please review.
webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java (line 56)
<https://reviews.apache.org/r/52995/#comment222850>
Consider replacing this with AtlasType.toJson(errorJsonMap)
- Madhan Neethiraj
On Oct. 20, 2016, 5:29 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52995/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 5:29 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1200
> https://issues.apache.org/jira/browse/ATLAS-1200
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
> AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
>
> Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
> intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
> webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
>
> Diff: https://reviews.apache.org/r/52995/diff/
>
>
> Testing
> -------
>
> Tested will REST API calls.
> Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/
-----------------------------------------------------------
(Updated Oct. 20, 2016, 5:29 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha GS, and Suma Shivaprasad.
Changes
-------
1. Added another field called error code for easier debugging.
2. Updated GraphStore to throw appropriate exceptions
Bugs: ATLAS-1200
https://issues.apache.org/jira/browse/ATLAS-1200
Repository: atlas
Description
-------
Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 5d3f4a38a7a34a973dc7bd43c3913c7b7925265b
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
Diff: https://reviews.apache.org/r/52995/diff/
Testing
-------
Tested will REST API calls.
Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
Thanks,
Apoorv Naik
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/
-----------------------------------------------------------
(Updated Oct. 20, 2016, 1:46 a.m.)
Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha GS, and Suma Shivaprasad.
Changes
-------
Removed unnecessary internal error code parameter.
Bugs: ATLAS-1200
https://issues.apache.org/jira/browse/ATLAS-1200
Repository: atlas
Description
-------
Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
Diff: https://reviews.apache.org/r/52995/diff/
Testing
-------
Tested will REST API calls.
Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
Thanks,
Apoorv Naik
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/
-----------------------------------------------------------
(Updated Oct. 20, 2016, 1:43 a.m.)
Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha GS, and Suma Shivaprasad.
Changes
-------
Moved the Error messages from the property files to Enum definition.
Bugs: ATLAS-1200
https://issues.apache.org/jira/browse/ATLAS-1200
Repository: atlas
Description
-------
Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 7b6e08a8b86889b64c57c82d53c55d0a9370e3b1
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 308a5294607ffb7d8c5938b9cde9f828da5043ee
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 5c55d421a43a3579595b76a84360b4cd5dfcc7c9
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java eeb08d0a4bdb4592e4837df410eb3097bd55d26a
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 065836143b3f2604ea6e3754069afea77e87f9c1
webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
Diff: https://reviews.apache.org/r/52995/diff/
Testing
-------
Tested will REST API calls.
Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
Thanks,
Apoorv Naik
Re: Review Request 52995: Error Catalog enhancement
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/
-----------------------------------------------------------
(Updated Oct. 18, 2016, 9:26 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha GS, and Suma Shivaprasad.
Bugs: ATLAS-1200
https://issues.apache.org/jira/browse/ATLAS-1200
Repository: atlas
Description
-------
Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters for the formatted error message.
AtlasErrorCode enum captures all AtlasErrors identified by a unique code such as AtlasE4001 etc.
Each error code has a error message/description which is mapped under errorMessage.properties (for I18N) and can be parameterized to provide more context about the failure.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/AtlasConstants.java 8521f630e202adc3024d7fd7a94a76c5a52771fa
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION
intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 3538f41355b23b60e79be4179cc7a05100bd7817
intg/src/main/resources/errorMessages.properties PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 78cbd635ba8d5ac2c1ae5144fec685f102dfc66e
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java f36c0d681ccff1c77fe0a35a1049e8cd54577fae
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 67ff1a0d842186e202ba14c3ba2a47193cbb7e2b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java ea1b03b661f265abcdb11cc1d9827d6196475638
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 4b50aacbc57a8ebd9b25febff3fc044082d4009a
webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 9830269d35aed961f0eecdfa6a57edf93e982de5
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 889c3dd0bf65c8bbfcb520ca6e9b72def07aed5f
webapp/src/main/webapp/WEB-INF/web.xml c5518142492dab0e343caf4cedbe8eb1a645364a
Diff: https://reviews.apache.org/r/52995/diff/
Testing
-------
Tested will REST API calls.
Unit Tests coverage will be added as a part of the UT review request for TypesREST stores.
Thanks,
Apoorv Naik