You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Michael McCandless <lu...@mikemccandless.com> on 2011/06/03 17:53:39 UTC
Re: svn commit: r1130977 - /lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java
I think this makes sense!
But could you backport to 3.x too...? Thanks.
Mike McCandless
http://blog.mikemccandless.com
On Fri, Jun 3, 2011 at 6:39 AM, <dw...@apache.org> wrote:
> Author: dweiss
> Date: Fri Jun 3 10:39:55 2011
> New Revision: 1130977
>
> URL: http://svn.apache.org/viewvc?rev=1130977&view=rev
> Log:
> Making NO_OUTPUT a true singleton within a single class loader. I didn't see the point of it being class-level, but correct me if I'm wrong.
>
> Modified:
> lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java
>
> Modified: lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java
> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java?rev=1130977&r1=1130976&r2=1130977&view=diff
> ==============================================================================
> --- lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java (original)
> +++ lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java Fri Jun 3 10:39:55 2011
> @@ -28,7 +28,7 @@ import org.apache.lucene.store.DataOutpu
>
> public final class NoOutputs extends Outputs<Object> {
>
> - final Object NO_OUTPUT = new Object() {
> + static final Object NO_OUTPUT = new Object() {
> // NodeHash calls hashCode for this output; we fix this
> // so we get deterministic hashing.
> @Override
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1130977 - /lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java
Posted by Michael McCandless <lu...@mikemccandless.com>.
Thanks!
Mike McCandless
http://blog.mikemccandless.com
On Fri, Jun 3, 2011 at 3:14 PM, Dawid Weiss
<da...@cs.put.poznan.pl> wrote:
> Done, thanks for reminding me.
>
> Dawid
>
> On Fri, Jun 3, 2011 at 5:53 PM, Michael McCandless
> <lu...@mikemccandless.com> wrote:
>> I think this makes sense!
>>
>> But could you backport to 3.x too...? Thanks.
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>> On Fri, Jun 3, 2011 at 6:39 AM, <dw...@apache.org> wrote:
>>> Author: dweiss
>>> Date: Fri Jun 3 10:39:55 2011
>>> New Revision: 1130977
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1130977&view=rev
>>> Log:
>>> Making NO_OUTPUT a true singleton within a single class loader. I didn't see the point of it being class-level, but correct me if I'm wrong.
>>>
>>> Modified:
>>> lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java
>>>
>>> Modified: lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java
>>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java?rev=1130977&r1=1130976&r2=1130977&view=diff
>>> ==============================================================================
>>> --- lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java (original)
>>> +++ lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java Fri Jun 3 10:39:55 2011
>>> @@ -28,7 +28,7 @@ import org.apache.lucene.store.DataOutpu
>>>
>>> public final class NoOutputs extends Outputs<Object> {
>>>
>>> - final Object NO_OUTPUT = new Object() {
>>> + static final Object NO_OUTPUT = new Object() {
>>> // NodeHash calls hashCode for this output; we fix this
>>> // so we get deterministic hashing.
>>> @Override
>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1130977 - /lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java
Posted by Dawid Weiss <da...@cs.put.poznan.pl>.
Done, thanks for reminding me.
Dawid
On Fri, Jun 3, 2011 at 5:53 PM, Michael McCandless
<lu...@mikemccandless.com> wrote:
> I think this makes sense!
>
> But could you backport to 3.x too...? Thanks.
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
> On Fri, Jun 3, 2011 at 6:39 AM, <dw...@apache.org> wrote:
>> Author: dweiss
>> Date: Fri Jun 3 10:39:55 2011
>> New Revision: 1130977
>>
>> URL: http://svn.apache.org/viewvc?rev=1130977&view=rev
>> Log:
>> Making NO_OUTPUT a true singleton within a single class loader. I didn't see the point of it being class-level, but correct me if I'm wrong.
>>
>> Modified:
>> lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java
>>
>> Modified: lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java
>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java?rev=1130977&r1=1130976&r2=1130977&view=diff
>> ==============================================================================
>> --- lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java (original)
>> +++ lucene/dev/trunk/lucene/src/java/org/apache/lucene/util/fst/NoOutputs.java Fri Jun 3 10:39:55 2011
>> @@ -28,7 +28,7 @@ import org.apache.lucene.store.DataOutpu
>>
>> public final class NoOutputs extends Outputs<Object> {
>>
>> - final Object NO_OUTPUT = new Object() {
>> + static final Object NO_OUTPUT = new Object() {
>> // NodeHash calls hashCode for this output; we fix this
>> // so we get deterministic hashing.
>> @Override
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org