You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by al...@apache.org on 2017/10/12 16:55:19 UTC
[1/2] beam git commit: Improve the documentation for CombineFn
Repository: beam
Updated Branches:
refs/heads/master 8e1caea64 -> 655227ab0
Improve the documentation for CombineFn
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/7b6556c7
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/7b6556c7
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/7b6556c7
Branch: refs/heads/master
Commit: 7b6556c7f7914be108945c2f877fe7e84ec057ba
Parents: 8e1caea
Author: Ahmet Altay <al...@google.com>
Authored: Wed Oct 11 17:52:35 2017 -0700
Committer: Ahmet Altay <al...@google.com>
Committed: Thu Oct 12 09:55:04 2017 -0700
----------------------------------------------------------------------
sdks/python/apache_beam/transforms/core.py | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/beam/blob/7b6556c7/sdks/python/apache_beam/transforms/core.py
----------------------------------------------------------------------
diff --git a/sdks/python/apache_beam/transforms/core.py b/sdks/python/apache_beam/transforms/core.py
index 41e20ba..e5f35c4 100644
--- a/sdks/python/apache_beam/transforms/core.py
+++ b/sdks/python/apache_beam/transforms/core.py
@@ -337,7 +337,7 @@ class DoFn(WithTypeHints, HasDisplayData, urns.RunnerApiFn):
f = getattr(self, func)
return inspect.getargspec(f)
- # TODO(sourabhbajaj): Do we want to remove the responsiblity of these from
+ # TODO(sourabhbajaj): Do we want to remove the responsibility of these from
# the DoFn or maybe the runner
def infer_output_type(self, input_type):
# TODO(robertwb): Side inputs types.
@@ -473,6 +473,10 @@ class CombineFn(WithTypeHints, HasDisplayData, urns.RunnerApiFn):
accumulator value left.
5. The extract_output operation is invoked on the final accumulator to get
the output value.
+
+ Note: If this **CombineFn** is used with a transform that has defaults,
+ **apply** will be called with an empty list at expansion time to get the
+ default value.
"""
def default_label(self):
[2/2] beam git commit: This closes #3984
Posted by al...@apache.org.
This closes #3984
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/655227ab
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/655227ab
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/655227ab
Branch: refs/heads/master
Commit: 655227ab0a077684735915fbdf7d0ada5cb5b3bf
Parents: 8e1caea 7b6556c
Author: Ahmet Altay <al...@google.com>
Authored: Thu Oct 12 09:55:09 2017 -0700
Committer: Ahmet Altay <al...@google.com>
Committed: Thu Oct 12 09:55:09 2017 -0700
----------------------------------------------------------------------
sdks/python/apache_beam/transforms/core.py | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------