You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "Leif Hedstrom (JIRA)" <ji...@apache.org> on 2010/03/22 22:33:27 UTC
[jira] Created: (TS-268) Crash when remap plugin tries to send a
redirect response.
Crash when remap plugin tries to send a redirect response.
----------------------------------------------------------
Key: TS-268
URL: https://issues.apache.org/jira/browse/TS-268
Project: Traffic Server
Issue Type: Bug
Reporter: Leif Hedstrom
Priority: Critical
Fix For: 2.0.0
Attachments: TS-268.trace
This remap API plugin will crash, when it tries to build the response body:
int
tsremap_remap(ihandle ih, rhandle rh, REMAP_REQUEST_INFO *rri)
{
const char* url = "http://www.google.com/";
INKHttpTxnSetHttpRetStatus((INKHttpTxn)rh, (INKHttpStatus)302);
rri->redirect_url_size = strlen(url);
memcpy(rri->redirect_url, url, rri->redirect_url_size);
return 1;
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-268) Crash when remap plugin tries to send a
redirect response.
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848374#action_12848374 ]
Leif Hedstrom commented on TS-268:
----------------------------------
In a debug build, it asserts instead:
http://pastebin.com/cFsptU4y
> Crash when remap plugin tries to send a redirect response.
> ----------------------------------------------------------
>
> Key: TS-268
> URL: https://issues.apache.org/jira/browse/TS-268
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Leif Hedstrom
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: TS-268.trace
>
>
> This remap API plugin will crash, when it tries to build the response body:
> int
> tsremap_remap(ihandle ih, rhandle rh, REMAP_REQUEST_INFO *rri)
> {
> const char* url = "http://www.google.com/";
> INKHttpTxnSetHttpRetStatus((INKHttpTxn)rh, (INKHttpStatus)302);
> rri->redirect_url_size = strlen(url);
> memcpy(rri->redirect_url, url, rri->redirect_url_size);
> return 1;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-268) Crash when remap plugin tries to send a
redirect response.
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-268:
-----------------------------
Attachment: TS-268.trace
This is a stack trace from a crash.
> Crash when remap plugin tries to send a redirect response.
> ----------------------------------------------------------
>
> Key: TS-268
> URL: https://issues.apache.org/jira/browse/TS-268
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Leif Hedstrom
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: TS-268.trace
>
>
> This remap API plugin will crash, when it tries to build the response body:
> int
> tsremap_remap(ihandle ih, rhandle rh, REMAP_REQUEST_INFO *rri)
> {
> const char* url = "http://www.google.com/";
> INKHttpTxnSetHttpRetStatus((INKHttpTxn)rh, (INKHttpStatus)302);
> rri->redirect_url_size = strlen(url);
> memcpy(rri->redirect_url, url, rri->redirect_url_size);
> return 1;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-268) Crash when remap plugin tries to send a
redirect response.
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848441#action_12848441 ]
Leif Hedstrom commented on TS-268:
----------------------------------
This is a slightly better backtrace from a non-debug build:
http://pastebin.com/u74sY4D7
> Crash when remap plugin tries to send a redirect response.
> ----------------------------------------------------------
>
> Key: TS-268
> URL: https://issues.apache.org/jira/browse/TS-268
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Leif Hedstrom
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: TS-268.trace
>
>
> This remap API plugin will crash, when it tries to build the response body:
> int
> tsremap_remap(ihandle ih, rhandle rh, REMAP_REQUEST_INFO *rri)
> {
> const char* url = "http://www.google.com/";
> INKHttpTxnSetHttpRetStatus((INKHttpTxn)rh, (INKHttpStatus)302);
> rri->redirect_url_size = strlen(url);
> memcpy(rri->redirect_url, url, rri->redirect_url_size);
> return 1;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-268) Crash when remap plugin tries to send a
redirect response.
Posted by "Steve Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Jiang resolved TS-268.
----------------------------
Resolution: Fixed
Fix Version/s: 2.1.0
Assignee: Steve Jiang
> Crash when remap plugin tries to send a redirect response.
> ----------------------------------------------------------
>
> Key: TS-268
> URL: https://issues.apache.org/jira/browse/TS-268
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Leif Hedstrom
> Assignee: Steve Jiang
> Priority: Critical
> Fix For: 2.1.0, 2.0.0
>
> Attachments: TS-268.trace
>
>
> This remap API plugin will crash, when it tries to build the response body:
> int
> tsremap_remap(ihandle ih, rhandle rh, REMAP_REQUEST_INFO *rri)
> {
> const char* url = "http://www.google.com/";
> INKHttpTxnSetHttpRetStatus((INKHttpTxn)rh, (INKHttpStatus)302);
> rri->redirect_url_size = strlen(url);
> memcpy(rri->redirect_url, url, rri->redirect_url_size);
> return 1;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-268) Crash when remap plugin tries to send a
redirect response.
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848361#action_12848361 ]
Leif Hedstrom commented on TS-268:
----------------------------------
The stacktrace is also available at
http://pastebin.com/YRLtZdxF
> Crash when remap plugin tries to send a redirect response.
> ----------------------------------------------------------
>
> Key: TS-268
> URL: https://issues.apache.org/jira/browse/TS-268
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Leif Hedstrom
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: TS-268.trace
>
>
> This remap API plugin will crash, when it tries to build the response body:
> int
> tsremap_remap(ihandle ih, rhandle rh, REMAP_REQUEST_INFO *rri)
> {
> const char* url = "http://www.google.com/";
> INKHttpTxnSetHttpRetStatus((INKHttpTxn)rh, (INKHttpStatus)302);
> rri->redirect_url_size = strlen(url);
> memcpy(rri->redirect_url, url, rri->redirect_url_size);
> return 1;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-268) Crash when remap plugin tries to send a
redirect response.
Posted by "Steve Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848483#action_12848483 ]
Steve Jiang commented on TS-268:
--------------------------------
ink_bvsprintf calls va_arg without calling va_copy or va_start. It looks like on 32-bit it doesn't matter, but on 64-bit it is not idempotent.
> Crash when remap plugin tries to send a redirect response.
> ----------------------------------------------------------
>
> Key: TS-268
> URL: https://issues.apache.org/jira/browse/TS-268
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Leif Hedstrom
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: TS-268.trace
>
>
> This remap API plugin will crash, when it tries to build the response body:
> int
> tsremap_remap(ihandle ih, rhandle rh, REMAP_REQUEST_INFO *rri)
> {
> const char* url = "http://www.google.com/";
> INKHttpTxnSetHttpRetStatus((INKHttpTxn)rh, (INKHttpStatus)302);
> rri->redirect_url_size = strlen(url);
> memcpy(rri->redirect_url, url, rri->redirect_url_size);
> return 1;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.