You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Devaraj Das (Created) (JIRA)" <ji...@apache.org> on 2012/04/05 02:15:18 UTC
[jira] [Created] (HIVE-2926) Expose some information about the
metastore through JMX
Expose some information about the metastore through JMX
-------------------------------------------------------
Key: HIVE-2926
URL: https://issues.apache.org/jira/browse/HIVE-2926
Project: Hive
Issue Type: Improvement
Components: Metastore
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.9.0
Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2926:
-----------------------------------
Fix Version/s: (was: 0.9.0)
Unlinking from 0.9
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Attachments: HIVE-2926.D2637.1.patch, HIVE-2926.D2655.1.patch, HIVE-2926.D2655.2.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2926:
------------------------------
Attachment: HIVE-2926.D2637.1.patch
ddraj requested code review of "HIVE-2926 [jira] Expose some information about the metastore through JMX".
Reviewers: JIRA
Adds VersionInfo and makes some metastore information exposed through JMX
Expose some information about the metastore through JMX
TEST PLAN
Did manual testing of the JMX stuff (including the version). Accessed the data through jconsole.
REVISION DETAIL
https://reviews.facebook.net/D2637
AFFECTED FILES
common/build.xml
common/saveVersion.sh
common/src/java/org/apache/hadoop/hive/common/HiveVersionAnnotation.java
common/src/java/org/apache/hadoop/hive/common/VersionInfo.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
metastore/src/java/org/apache/hadoop/hive/metastore/MXBean.java
metastore/src/java/org/apache/hadoop/hive/metastore/MXBeanImpl.java
ql/src/test/results/clientnegative/column_rename1.q.out
ql/src/test/results/clientnegative/column_rename4.q.out
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/6063/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Carl Steinbach (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247784#comment-13247784 ]
Carl Steinbach commented on HIVE-2926:
--------------------------------------
Sounds good. Please submit a phabricator request (https://cwiki.apache.org/Hive/phabricatorcodereview.html) when the patch is ready for review.
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248771#comment-13248771 ]
Phabricator commented on HIVE-2926:
-----------------------------------
ddraj has added reviewers to the revision "HIVE-2926 [jira] Expose some information about the metastore through JMX".
Added Reviewers: cwsteinbach
Sorry Carl, I messed up my workspace and I had to generate a fresh review request instead of updating the previous patch with your comments incorporated.. I took into consideration most of your comments. I made some changes to fix issues found in my testing.
REVISION DETAIL
https://reviews.facebook.net/D2655
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, HIVE-2926.D2655.1.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252931#comment-13252931 ]
Phabricator commented on HIVE-2926:
-----------------------------------
ashutoshc has requested changes to the revision "HIVE-2926 [jira] Expose some information about the metastore through JMX".
Looks good.
INLINE COMMENTS
build-common.xml:223 Can you add a check here that do this only if bash is available? Then, you can skip this step, instead of failing.
REVISION DETAIL
https://reviews.facebook.net/D2655
BRANCH
hive-2926.1
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, HIVE-2926.D2655.1.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253575#comment-13253575 ]
Phabricator commented on HIVE-2926:
-----------------------------------
ashutoshc has requested changes to the revision "HIVE-2926 [jira] Expose some information about the metastore through JMX".
Patch needs to be rebased.
INLINE COMMENTS
build-common.xml:223 Seems like this will fail if bash is not in environment.
build-common.xml:241 This is not required here. You already have it in common/build.xml thats sufficient.
REVISION DETAIL
https://reviews.facebook.net/D2655
BRANCH
hive-2926.1
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, HIVE-2926.D2655.1.patch, HIVE-2926.D2655.2.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253685#comment-13253685 ]
Phabricator commented on HIVE-2926:
-----------------------------------
cwsteinbach has commented on the revision "HIVE-2926 [jira] Expose some information about the metastore through JMX".
I applied the patch and tried building against a git repository. A couple comments about the results:
* package-info.java files are currently generated for the common, contrib, and hbase-handler subprojects. This file is not getting generated for other subprojects because they currently define their own compile target. The subprojects should either inherit the compile target defined in build-commmon.xml, or else be modified to explicitly depend on the new pkg-info target.
* Here's the contents of the package-info.java file in the hbase-handler directory:
@HiveVersionAnnotation(version="0.10.0-SNAPSHOT",
revision="427ddadb8fb62de5f97b33e038e26fab80ec3653",
user="carl",
date="Fri Apr 13 12:08:12 PDT 2012",
repositoryUrl="git://Carls-MacBook-Pro.local/ on branch arcpatch-D2655")
package org.apache.hadoop.hive.common;
* I think we should use the abbreviated commit hash (%h) instead of the full commit hash (%H).
* The repository URL is bogus. For Git it probably only makes sense to list the commit hash (which is a GUID).
* The package should be org.apache.hadoop.hive.hbase-handler.
* Given a Hive JAR file, I think there should be some way of dumping the version info and commit hash. This can be accomplished by including it in the JAR manifest, or by defining a VersionInfo and associated main() which the JAR file's Main-Class manifest attribute points to.
REVISION DETAIL
https://reviews.facebook.net/D2655
BRANCH
hive-2926.1
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, HIVE-2926.D2655.1.patch, HIVE-2926.D2655.2.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2926:
------------------------------
Attachment: HIVE-2926.D2655.2.patch
ddraj updated the revision "HIVE-2926 [jira] Expose some information about the metastore through JMX".
Reviewers: JIRA, cwsteinbach, ashutoshc
Addressed Ashutosh's & Carl's comments.
REVISION DETAIL
https://reviews.facebook.net/D2655
AFFECTED FILES
build-common.xml
common/build.xml
common/src/java/org/apache/hadoop/hive/common/HiveVersionAnnotation.java
common/src/java/org/apache/hadoop/hive/common/VersionInfo.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
metastore/src/java/org/apache/hadoop/hive/metastore/MXBean.java
metastore/src/java/org/apache/hadoop/hive/metastore/MXBeanImpl.java
saveVersion.sh
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, HIVE-2926.D2655.1.patch, HIVE-2926.D2655.2.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253597#comment-13253597 ]
Phabricator commented on HIVE-2926:
-----------------------------------
cwsteinbach has commented on the revision "HIVE-2926 [jira] Expose some information about the metastore through JMX".
INLINE COMMENTS
common/build.xml:30 I think we can remove the compile target defined in common/build.xml and instead inherit the one defined in build-common.xml
build-common.xml:232 Please remove this change and instead define a src.dir property above similar to test.src.dir.
common/src/java/org/apache/hadoop/hive/common/VersionInfo.java:83 The "-r" prefix doesn't make sense for Git hashtags.
metastore/src/java/org/apache/hadoop/hive/metastore/MXBean.java:45 Change the name to "isSaslEnabled()"
build-common.xml:223 I think it would be better to make saveVersion.sh executable and call it directly, instead of invoking it via bash.
build-common.xml:241 It's not sufficient because we want to annotate all of the JARs with this information.
As an aside, I think it would be preferable to write the generated package-info.java file to the src.dir and update .gitignore/svn:ignore to ignore these files. This approach obviates the need to run javac twice.
saveVersion.sh:49 These fields need to be parameterized since we're using this script to annotate all of the JARs with package info.
saveVersion.sh:43 Please parameterize this.
REVISION DETAIL
https://reviews.facebook.net/D2655
BRANCH
hive-2926.1
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, HIVE-2926.D2655.1.patch, HIVE-2926.D2655.2.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Devaraj Das (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HIVE-2926:
------------------------------
Attachment: hive-2926.1.patch
@Ashutosh the patch attached here has been tested. Yes this assumes executables like 'sed'. I don't have a better solution at this point for handling that issue. The way version is derived in this patch is similar to the way Hadoop/HBase does..
@Carl, I changed the 'sh' to 'bash'
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247852#comment-13247852 ]
Phabricator commented on HIVE-2926:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2926 [jira] Expose some information about the metastore through JMX".
INLINE COMMENTS
common/src/java/org/apache/hadoop/hive/common/HiveVersionAnnotation.java:26 Comment should reference Hive instead of Hadoop. Same thing applies to several of the comments below.
common/src/java/org/apache/hadoop/hive/common/VersionInfo.java:101 Change to "Apache Hive"
ql/src/test/results/clientnegative/column_rename1.q.out:26 These q file updates don't belong here, right?
common/build.xml:30 I think this target should be moved into build-common.xml and should get called for all sub-projects. This will make it a lot easier to diagnose cases where people are using JARs from different versions of Hive.
common/src/java/org/apache/hadoop/hive/common/HiveVersionAnnotation.java:50 According to saveVersion.sh this could also return the URL for a Git repo. The comment should be updated to reflect this, and I think the name of the method should be changed to "getRepositoryUrl()"
common/src/java/org/apache/hadoop/hive/common/HiveVersionAnnotation.java:55 Ditto.
common/src/java/org/apache/hadoop/hive/common/VersionInfo.java:75 "source code repository URL"
common/src/java/org/apache/hadoop/hive/common/VersionInfo.java:95 Does it make sense to reference a revision number without also mentioning the repository URL?
common/src/java/org/apache/hadoop/hive/common/VersionInfo.java:102 This references svn. What if this was built using git?
metastore/src/java/org/apache/hadoop/hive/metastore/MXBeanImpl.java:33 This assumes that VersionInfo.getRevision() returns an SVN revision number.
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:3060 Does it make sense to include minWorkerThreads, or the value of hive.metastore.uris? What about the value of useSasl or tcpKeepAlive?
REVISION DETAIL
https://reviews.facebook.net/D2637
BRANCH
HIVE-2926-branch
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247743#comment-13247743 ]
Ashutosh Chauhan commented on HIVE-2926:
----------------------------------------
Couple of comments:
* This assumes sh, cat, sed etc. to be available in the environment. So, it may not work where these tools are not present, which is fine but thought to point this out. I tested on mac and linux, it builds fine.
* I don't see how your generated package-info.java will get compiled. You create a .java file in build dir. Have you tested that it works as you expect?
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247840#comment-13247840 ]
Phabricator commented on HIVE-2926:
-----------------------------------
ddraj has commented on the revision "HIVE-2926 [jira] Expose some information about the metastore through JMX".
Ignore the two patch changes in *.out files. I don't know how these crept in.
REVISION DETAIL
https://reviews.facebook.net/D2637
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Devaraj Das (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HIVE-2926:
------------------------------
Attachment: metastore-jmx.patch
This patch adds MXBean interface to the metastore package. Some bits of information like the hostname and version are exposed through the implementation of the interface.
I also added the HiveVersionAnnotation similar to Hadoop to facilitate the MXBean implementation.
Under test..
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252932#comment-13252932 ]
Phabricator commented on HIVE-2926:
-----------------------------------
cwsteinbach has commented on the revision "HIVE-2926 [jira] Expose some information about the metastore through JMX".
INLINE COMMENTS
saveVersion.sh:1 Please change this to "#!/usr/bin/env bash"
REVISION DETAIL
https://reviews.facebook.net/D2655
BRANCH
hive-2926.1
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, HIVE-2926.D2655.1.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247820#comment-13247820 ]
Phabricator commented on HIVE-2926:
-----------------------------------
ddraj has added reviewers to the revision "HIVE-2926 [jira] Expose some information about the metastore through JMX".
Added Reviewers: ashutoshc, khorgath, cwsteinbach
REVISION DETAIL
https://reviews.facebook.net/D2637
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2926:
------------------------------
Attachment: HIVE-2926.D2655.1.patch
ddraj requested code review of "HIVE-2926 [jira] Expose some information about the metastore through JMX".
Reviewers: JIRA
Patch that exposes some additional details in the metastore through jmx
Expose some information about the metastore through JMX
TEST PLAN
Manually tested
REVISION DETAIL
https://reviews.facebook.net/D2655
AFFECTED FILES
build-common.xml
common/build.xml
common/src/java/org/apache/hadoop/hive/common/HiveVersionAnnotation.java
common/src/java/org/apache/hadoop/hive/common/VersionInfo.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
metastore/src/java/org/apache/hadoop/hive/metastore/MXBean.java
metastore/src/java/org/apache/hadoop/hive/metastore/MXBeanImpl.java
saveVersion.sh
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/6105/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, HIVE-2926.D2655.1.patch, hive-2926.1.patch, metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2926) Expose some information about the
metastore through JMX
Posted by "Carl Steinbach (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247759#comment-13247759 ]
Carl Steinbach commented on HIVE-2926:
--------------------------------------
bin/hive uses Bash. I think we should do the same thing here. Also note that on most platforms /bin/sh actually maps to bash, or to something entirely different (e.g. https://wiki.ubuntu.com/DashAsBinSh).
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira