You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/12 02:47:55 UTC

[GitHub] [incubator-dolphinscheduler] samz406 opened a new pull request #1941: modify DataAnalysisServiceTest by mock

samz406 opened a new pull request #1941: modify DataAnalysisServiceTest by mock
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1941
 
 
   For #1465
   modify DataAnalysisServiceTest 
   modify DataAnalysisService
   
   modify root pom
   
   `<include>**/api/service/DataAnalysisServiceTest.java</include>`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1941: modify DataAnalysisServiceTest by mock

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #1941: modify DataAnalysisServiceTest by mock
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1941#issuecomment-584993934
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941?src=pr&el=h1) Report
   > Merging [#1941](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/4bb044a41de1869e439c6c325069d90d712875d1?src=pr&el=desc) will **increase** coverage by `0.55%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##               dev    #1941      +/-   ##
   ===========================================
   + Coverage     25.8%   26.35%   +0.55%     
   - Complexity       0     1347    +1347     
   ===========================================
     Files          297      312      +15     
     Lines        14332    16642    +2310     
     Branches      2351     2048     -303     
   ===========================================
   + Hits          3698     4386     +688     
   - Misses       10181    11784    +1603     
   - Partials       453      472      +19
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...phinscheduler/api/service/DataAnalysisService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YUFuYWx5c2lzU2VydmljZS5qYXZh) | `81.65% <66.66%> (+81.05%)` | `21 <0> (+21)` | :arrow_up: |
   | [...dolphinscheduler/common/utils/EncryptionUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0VuY3J5cHRpb25VdGlscy5qYXZh) | `50% <0%> (-50%)` | `2% <0%> (+2%)` | |
   | [...lphinscheduler/common/utils/SensitiveLogUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1NlbnNpdGl2ZUxvZ1V0aWxzLmphdmE=) | `75% <0%> (-25%)` | `2% <0%> (+2%)` | |
   | [.../apache/dolphinscheduler/common/utils/ResInfo.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1Jlc0luZm8uamF2YQ==) | `78.04% <0%> (-14.55%)` | `10% <0%> (+10%)` | |
   | [...che/dolphinscheduler/common/utils/StringUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1N0cmluZ1V0aWxzLmphdmE=) | `85.71% <0%> (-14.29%)` | `10% <0%> (+10%)` | |
   | [.../api/utils/exportprocess/TaskNodeParamFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL2V4cG9ydHByb2Nlc3MvVGFza05vZGVQYXJhbUZhY3RvcnkuamF2YQ==) | `66.66% <0%> (-13.34%)` | `3% <0%> (+3%)` | |
   | [...apache/dolphinscheduler/common/thread/Stopper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9TdG9wcGVyLmphdmE=) | `66.66% <0%> (-13.34%)` | `4% <0%> (+4%)` | |
   | [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `0% <0%> (-13.12%)` | `0% <0%> (ø)` | |
   | [...che/dolphinscheduler/common/enums/CommandType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0NvbW1hbmRUeXBlLmphdmE=) | `88.88% <0%> (-11.12%)` | `2% <0%> (+2%)` | |
   | [...apache/dolphinscheduler/alert/utils/FuncUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9GdW5jVXRpbHMuamF2YQ==) | `91.66% <0%> (-8.34%)` | `5% <0%> (+5%)` | |
   | ... and [271 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941?src=pr&el=footer). Last update [4bb044a...735034c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] samz406 merged pull request #1941: modify DataAnalysisServiceTest by mock

Posted by GitBox <gi...@apache.org>.

samz406 merged pull request #1941: modify DataAnalysisServiceTest by mock
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1941
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1941: modify DataAnalysisServiceTest by mock

Posted by GitBox <gi...@apache.org>.

sonarcloud[bot] commented on issue #1941: modify DataAnalysisServiceTest by mock
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1941#issuecomment-584998425
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1941&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1941&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1941&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1941&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1941&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1941&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1941&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1941&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1941&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1941&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1941&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='80.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1941&metric=new_coverage&view=list) [80.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1941&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1941&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1941&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services