[GitHub] [spark] turboFei removed a comment on issue #24533: [SPARK-27637][Shuffle] For nettyBlockTransferService, if IOException occurred while fetching data, check whether relative executor is alive before retry

[GitBox <gi...@apache.org>]

turboFei removed a comment on issue #24533: [SPARK-27637][Shuffle] For nettyBlockTransferService, if IOException occurred while fetching data, check whether relative executor is alive  before retry
URL: https://github.com/apache/spark/pull/24533#issuecomment-492185517
 
 
   > when will we use the default null value? only in test?
   
   Yes, the default null value is only used in test.
   So, I think we don't need add safeguard when driverEndPointRef is null.
   
   > This is the code we want to test, we should not put it in the test...
   
   Get it, I wanted to prove that the retryingBlockFetch would not retry when the relative executor is dead. I have remove this part. 
   @cloud-fan Thanks
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org