You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/22 13:31:38 UTC

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2101: feature: customed config.yaml when apisix start

Yiyiyimu commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r475091197



##########
File path: .travis/apisix_cli_test.sh
##########
@@ -204,3 +204,26 @@ fi
 
 sed -i 's/worker_processes: 2/worker_processes: auto/'  conf/config.yaml
 echo "passed: worker_processes number is configurable"
+
+# check customed config.yaml is copied.
+
+git checkout conf/config.yaml
+
+echo "
+nginx_config:
+    worker_processes: 2
+" > conf/customed_config.yaml
+
+make default
+./bin/apisix init
+./bin/apisix init_etcd
+./bin/apisix start -c conf/customed_config.yaml

Review comment:
       test needs to improve. call `apisix start` here would failed.
   
   **Need suggestions!**




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org