You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/02/24 14:04:01 UTC

[GitHub] zeppelin pull request #2066: [ZEPPELIN-1725] replace cleanDirectory with for...

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/2066

    [ZEPPELIN-1725] replace cleanDirectory with forceDelete

    ### What is this PR for?
    At times while updating dependency from Interpreter settings page it fails with 
    
    ```
    ERROR [2017-02-24 12:56:03,503] ({Thread-87} InterpreterFactory.java[run]:550) - Error while downloading repos for interpreter group : jdbc, go to interpreter setting page click on edit and save it again to make this interpreter work properly. : Unable to delete file: /home/prabhu/zeppelin-server/local-repo/2CBX1E3VP/jcip-annotations-1.0.jar
    java.io.IOException: Unable to delete file: /home/prabhu/zeppelin-server/local-repo/2CBX1E3VP/jcip-annotations-1.0.jar
            at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2279)
            at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
            at org.apache.zeppelin.interpreter.InterpreterFactory$3.run(InterpreterFactory.java:550)
    ```
    
    Hence, I propose to replace cleanDirectory with forceDelete
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * [ZEPPELIN-1725](https://issues.apache.org/jira/browse/ZEPPELIN-1725)
    
    ### How should this be tested?
    Try adding and removing dependency say "org.apache.hive:hive-jdbc::standalone:1.2.1000" in JDBC interpreter, it does not fails always, but once in a while.
    
    ### Screenshots (if appropriate)
    N/A
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1725-v2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2066.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2066
    
----
commit 21b32a0b99ac1c806d2a419bd2e73f9ab85886e2
Author: Prabhjyot Singh <pr...@gmail.com>
Date:   2017-02-24T13:55:08Z

    replace cleanDirectory with forceDelete

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2066: [ZEPPELIN-1725] replace cleanDirectory with forceDelet...

Posted by r-kamath <gi...@git.apache.org>.

Github user r-kamath commented on the issue:

    https://github.com/apache/zeppelin/pull/2066
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2066: [ZEPPELIN-1725] replace cleanDirectory with for...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2066


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2066: [ZEPPELIN-1725] replace cleanDirectory with forceDelet...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2066
  
    Merging this to master and branch-0.7 if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---