You are viewing a plain text version of this content. The canonical link for it is here.

Posted to hcatalog-commits@incubator.apache.org by "Ashutosh Chauhan (JIRA)" <ji...@apache.org> on 2011/05/05 17:44:03 UTC

[jira] [Commented] (HCATALOG-18) Refactor TestRCFileInputStorageDriver

    [ https://issues.apache.org/jira/browse/HCATALOG-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029458#comment-13029458 ] 

Ashutosh Chauhan commented on HCATALOG-18:
------------------------------------------

+1 refactoring looks good. TestPermsInheritance doesnt fail for me with or without a patch. So, I will go ahead and commit the patch. Jakob, if you have a reproducible case for it to be failing, can you file a separate Jira.

> Refactor TestRCFileInputStorageDriver
> -------------------------------------
>
>                 Key: HCATALOG-18
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-18
>             Project: HCatalog
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: refactor_TestRCFileInputStorageDriver.patch
>
>
> TestRCFileInputStorageDriver has a lot of duplicated code and doesn't use the most efficient collections code.  This patch shaves about 80 lines off and focuses more on the tests themselves.  Tests pass, except for some reason TestPermsInheritance is failing for me now with or without this patch.  I don't believe it's related.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira