You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2016/12/07 11:04:44 UTC
Re: Review Request 54255: Update to Mesos 1.1.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/
-----------------------------------------------------------
(Updated Dec. 7, 2016, 12:04 p.m.)
Review request for Aurora, Joshua Cohen and Zameer Manji.
Summary (updated)
-----------------
Update to Mesos 1.1.0.
Bugs: AURORA-1813
https://issues.apache.org/jira/browse/AURORA-1813
Repository: aurora
Description (updated)
-------
Included changes:
* Handle new task states introduced in the latest Mesos release.
* Prevent NullPointer exception when inspecting an empty/invalid executor config in a test.
Probably this is due to a change in the Mesos protobufs.
* Fix bug preventing the teardown of Vagrant boxes started by the egg build.
* Increase resources for the Mesos egg builds. The build for all distribution now takes 2h in total.
Diffs (updated)
-----
3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126
RELEASE-NOTES.md 90c4793b218f54ad92ab4da5049d5e92c3a104b3
Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4
build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd
build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca
build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a
src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
Diff: https://reviews.apache.org/r/54255/diff/
Testing (updated)
-------
./gradlew -Pq build
./pants test.pytest src/{main,test}/python:: -- -v
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Stephan Erb
Re: Review Request 54255: Update to Mesos 1.1.0.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/#review159575
-----------------------------------------------------------
Master (c42b1af) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 18, 2016, 12:09 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54255/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2016, 12:09 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1813
> https://issues.apache.org/jira/browse/AURORA-1813
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Included changes:
>
> * Handle new task states introduced in the latest Mesos release.
> * Prevent NullPointer exception when inspecting an empty/invalid executor config in a test.
> Probably this is due to a change in the Mesos protobufs.
> * Fix bug preventing the teardown of Vagrant boxes started by the egg build.
> * Increase resources for the Mesos egg builds. The build for all distribution now takes 2h in total.
>
> Full Mesos changelog: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=1.1.0
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126
> RELEASE-NOTES.md a7925948791d540ab1a96c9d0aff2a274a75ee3d
> Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4
> build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd
> build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca
> build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a
> src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
>
> Diff: https://reviews.apache.org/r/54255/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (run both with Mesos 1.0 and Mesos 1.1)
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 54255: Update to Mesos 1.1.0.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/#review159660
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Dec. 18, 2016, 4:09 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54255/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2016, 4:09 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1813
> https://issues.apache.org/jira/browse/AURORA-1813
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Included changes:
>
> * Handle new task states introduced in the latest Mesos release.
> * Prevent NullPointer exception when inspecting an empty/invalid executor config in a test.
> Probably this is due to a change in the Mesos protobufs.
> * Fix bug preventing the teardown of Vagrant boxes started by the egg build.
> * Increase resources for the Mesos egg builds. The build for all distribution now takes 2h in total.
>
> Full Mesos changelog: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=1.1.0
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126
> RELEASE-NOTES.md a7925948791d540ab1a96c9d0aff2a274a75ee3d
> Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4
> build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd
> build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca
> build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a
> src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
>
> Diff: https://reviews.apache.org/r/54255/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (run both with Mesos 1.0 and Mesos 1.1)
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 54255: Update to Mesos 1.1.0.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/
-----------------------------------------------------------
(Updated Dec. 18, 2016, 1:09 p.m.)
Review request for Aurora, Joshua Cohen and Zameer Manji.
Changes
-------
Fix rebase gone wrong.
Bugs: AURORA-1813
https://issues.apache.org/jira/browse/AURORA-1813
Repository: aurora
Description
-------
Included changes:
* Handle new task states introduced in the latest Mesos release.
* Prevent NullPointer exception when inspecting an empty/invalid executor config in a test.
Probably this is due to a change in the Mesos protobufs.
* Fix bug preventing the teardown of Vagrant boxes started by the egg build.
* Increase resources for the Mesos egg builds. The build for all distribution now takes 2h in total.
Full Mesos changelog: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=1.1.0
Diffs (updated)
-----
3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126
RELEASE-NOTES.md a7925948791d540ab1a96c9d0aff2a274a75ee3d
Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4
build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd
build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca
build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a
src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
Diff: https://reviews.apache.org/r/54255/diff/
Testing
-------
./gradlew -Pq build
./pants test.pytest src/{main,test}/python:: -- -v
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (run both with Mesos 1.0 and Mesos 1.1)
Thanks,
Stephan Erb
Re: Review Request 54255: Update to Mesos 1.1.0.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/
-----------------------------------------------------------
(Updated Dec. 18, 2016, 1:08 p.m.)
Review request for Aurora, Joshua Cohen and Zameer Manji.
Changes
-------
Rebase.
Bugs: AURORA-1813
https://issues.apache.org/jira/browse/AURORA-1813
Repository: aurora
Description
-------
Included changes:
* Handle new task states introduced in the latest Mesos release.
* Prevent NullPointer exception when inspecting an empty/invalid executor config in a test.
Probably this is due to a change in the Mesos protobufs.
* Fix bug preventing the teardown of Vagrant boxes started by the egg build.
* Increase resources for the Mesos egg builds. The build for all distribution now takes 2h in total.
Full Mesos changelog: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=1.1.0
Diffs (updated)
-----
3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126
RELEASE-NOTES.md a7925948791d540ab1a96c9d0aff2a274a75ee3d
Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4
build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd
build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca
build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a
src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
Diff: https://reviews.apache.org/r/54255/diff/
Testing
-------
./gradlew -Pq build
./pants test.pytest src/{main,test}/python:: -- -v
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (run both with Mesos 1.0 and Mesos 1.1)
Thanks,
Stephan Erb
Re: Review Request 54255: Update to Mesos 1.1.0.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/
-----------------------------------------------------------
(Updated Dec. 18, 2016, 1:05 p.m.)
Review request for Aurora, Joshua Cohen and Zameer Manji.
Bugs: AURORA-1813
https://issues.apache.org/jira/browse/AURORA-1813
Repository: aurora
Description (updated)
-------
Included changes:
* Handle new task states introduced in the latest Mesos release.
* Prevent NullPointer exception when inspecting an empty/invalid executor config in a test.
Probably this is due to a change in the Mesos protobufs.
* Fix bug preventing the teardown of Vagrant boxes started by the egg build.
* Increase resources for the Mesos egg builds. The build for all distribution now takes 2h in total.
Full Mesos changelog: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=1.1.0
Diffs (updated)
-----
3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126
RELEASE-NOTES.md 90c4793b218f54ad92ab4da5049d5e92c3a104b3
Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4
build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd
build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca
build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a
src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
Diff: https://reviews.apache.org/r/54255/diff/
Testing (updated)
-------
./gradlew -Pq build
./pants test.pytest src/{main,test}/python:: -- -v
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (run both with Mesos 1.0 and Mesos 1.1)
Thanks,
Stephan Erb
Re: Review Request 54255: Update to Mesos 1.1.0.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/#review158327
-----------------------------------------------------------
Master (91ddb07) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 7, 2016, 11:04 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54255/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 11:04 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1813
> https://issues.apache.org/jira/browse/AURORA-1813
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Included changes:
>
> * Handle new task states introduced in the latest Mesos release.
> * Prevent NullPointer exception when inspecting an empty/invalid executor config in a test.
> Probably this is due to a change in the Mesos protobufs.
> * Fix bug preventing the teardown of Vagrant boxes started by the egg build.
> * Increase resources for the Mesos egg builds. The build for all distribution now takes 2h in total.
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126
> RELEASE-NOTES.md 90c4793b218f54ad92ab4da5049d5e92c3a104b3
> Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4
> build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd
> build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca
> build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a
> src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
>
> Diff: https://reviews.apache.org/r/54255/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 54255: Update to Mesos 1.1.0.
Posted by Stephan Erb <se...@apache.org>.
> On Dec. 7, 2016, 10:35 p.m., Joshua Cohen wrote:
> > Can you add links to the Mesos release notes to the review?
Done
> On Dec. 7, 2016, 10:35 p.m., Joshua Cohen wrote:
> > RELEASE-NOTES.md, line 5
> > <https://reviews.apache.org/r/54255/diff/2/?file=1578552#file1578552line5>
> >
> > 1.1.0 ;)
Woops. Fixed :)
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/#review158355
-----------------------------------------------------------
On Dec. 18, 2016, 1:05 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54255/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2016, 1:05 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1813
> https://issues.apache.org/jira/browse/AURORA-1813
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Included changes:
>
> * Handle new task states introduced in the latest Mesos release.
> * Prevent NullPointer exception when inspecting an empty/invalid executor config in a test.
> Probably this is due to a change in the Mesos protobufs.
> * Fix bug preventing the teardown of Vagrant boxes started by the egg build.
> * Increase resources for the Mesos egg builds. The build for all distribution now takes 2h in total.
>
> Full Mesos changelog: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=1.1.0
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126
> RELEASE-NOTES.md 90c4793b218f54ad92ab4da5049d5e92c3a104b3
> Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4
> build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd
> build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca
> build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a
> src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
>
> Diff: https://reviews.apache.org/r/54255/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (run both with Mesos 1.0 and Mesos 1.1)
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 54255: Update to Mesos 1.1.0.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/#review158355
-----------------------------------------------------------
Ship it!
Can you add links to the Mesos release notes to the review?
RELEASE-NOTES.md (line 5)
<https://reviews.apache.org/r/54255/#comment229120>
1.1.0 ;)
- Joshua Cohen
On Dec. 7, 2016, 11:04 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54255/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 11:04 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1813
> https://issues.apache.org/jira/browse/AURORA-1813
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Included changes:
>
> * Handle new task states introduced in the latest Mesos release.
> * Prevent NullPointer exception when inspecting an empty/invalid executor config in a test.
> Probably this is due to a change in the Mesos protobufs.
> * Fix bug preventing the teardown of Vagrant boxes started by the egg build.
> * Increase resources for the Mesos egg builds. The build for all distribution now takes 2h in total.
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126
> RELEASE-NOTES.md 90c4793b218f54ad92ab4da5049d5e92c3a104b3
> Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4
> build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd
> build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca
> build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a
> src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
>
> Diff: https://reviews.apache.org/r/54255/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 54255: Update to Mesos 1.1.0.
Posted by Stephan Erb <se...@apache.org>.
> On Dec. 7, 2016, 8:19 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/base/Conversions.java, line 67
> > <https://reviews.apache.org/r/54255/diff/2/?file=1578557#file1578557line67>
> >
> > Can you reference AURORA-1814 in this comment please?
Done
> On Dec. 7, 2016, 8:19 p.m., Zameer Manji wrote:
> > build-support/python/make-mesos-native-egg, line 61
> > <https://reviews.apache.org/r/54255/diff/2/?file=1578555#file1578555line61>
> >
> > I think here we want to set the `MAKEFLAGS` environment variable instead.
> >
> > https://www.gnu.org/software/make/manual/html_node/Options_002fRecursion.html
> >
> > ```
> > The \u2018-j\u2019 option is a special case (see Parallel Execution). If you set it to some numeric value \u2018N\u2019 and your operating system supports it (most any UNIX system will; others typically won\u2019t), the parent make and all the sub-makes will communicate to ensure that there are only \u2018N\u2019 jobs running at the same time between them all. Note that any job that is marked recursive (see Instead of Executing Recipes) doesn\u2019t count against the total jobs (otherwise we could get \u2018N\u2019 sub-makes running and have no slots left over for any real work!)
> > ```
> >
> > I think the mesos make files have recursive make invocations in them, so this is more desirable.
Done
> On Dec. 7, 2016, 8:19 p.m., Zameer Manji wrote:
> > RELEASE-NOTES.md, line 5
> > <https://reviews.apache.org/r/54255/diff/2/?file=1578552#file1578552line5>
> >
> > You mean 1.1.0 right?
Fixed
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/#review158370
-----------------------------------------------------------
On Dec. 18, 2016, 1:05 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54255/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2016, 1:05 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1813
> https://issues.apache.org/jira/browse/AURORA-1813
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Included changes:
>
> * Handle new task states introduced in the latest Mesos release.
> * Prevent NullPointer exception when inspecting an empty/invalid executor config in a test.
> Probably this is due to a change in the Mesos protobufs.
> * Fix bug preventing the teardown of Vagrant boxes started by the egg build.
> * Increase resources for the Mesos egg builds. The build for all distribution now takes 2h in total.
>
> Full Mesos changelog: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=1.1.0
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126
> RELEASE-NOTES.md 90c4793b218f54ad92ab4da5049d5e92c3a104b3
> Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4
> build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd
> build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca
> build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a
> src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
>
> Diff: https://reviews.apache.org/r/54255/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (run both with Mesos 1.0 and Mesos 1.1)
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 54255: Update to Mesos 1.1.0.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/#review158370
-----------------------------------------------------------
RELEASE-NOTES.md (line 5)
<https://reviews.apache.org/r/54255/#comment229131>
You mean 1.1.0 right?
build-support/python/make-mesos-native-egg (line 60)
<https://reviews.apache.org/r/54255/#comment229136>
I think here we want to set the `MAKEFLAGS` environment variable instead.
https://www.gnu.org/software/make/manual/html_node/Options_002fRecursion.html
```
The \u2018-j\u2019 option is a special case (see Parallel Execution). If you set it to some numeric value \u2018N\u2019 and your operating system supports it (most any UNIX system will; others typically won\u2019t), the parent make and all the sub-makes will communicate to ensure that there are only \u2018N\u2019 jobs running at the same time between them all. Note that any job that is marked recursive (see Instead of Executing Recipes) doesn\u2019t count against the total jobs (otherwise we could get \u2018N\u2019 sub-makes running and have no slots left over for any real work!)
```
I think the mesos make files have recursive make invocations in them, so this is more desirable.
src/main/java/org/apache/aurora/scheduler/base/Conversions.java (line 67)
<https://reviews.apache.org/r/54255/#comment229137>
Can you reference AURORA-1814 in this comment please?
- Zameer Manji
On Dec. 7, 2016, 3:04 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54255/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 3:04 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1813
> https://issues.apache.org/jira/browse/AURORA-1813
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Included changes:
>
> * Handle new task states introduced in the latest Mesos release.
> * Prevent NullPointer exception when inspecting an empty/invalid executor config in a test.
> Probably this is due to a change in the Mesos protobufs.
> * Fix bug preventing the teardown of Vagrant boxes started by the egg build.
> * Increase resources for the Mesos egg builds. The build for all distribution now takes 2h in total.
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126
> RELEASE-NOTES.md 90c4793b218f54ad92ab4da5049d5e92c3a104b3
> Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4
> build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd
> build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca
> build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a
> src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
>
> Diff: https://reviews.apache.org/r/54255/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 54255: Update to Mesos 1.1.0.
Posted by Stephan Erb <se...@apache.org>.
> On Dec. 7, 2016, 7:14 p.m., David McLaughlin wrote:
> > Re: Testing Done. Can you verify this build of Aurora also runs on Mesos 1.0.0, even if it's just manual verification? I'm not sure the implication of using those constants - were they also in Mesos 1.0.0?
>
> Zameer Manji wrote:
> The constatns were not in the Mesos 1.0.0 protbuf, but they are here now.
>
> We cannot recieve these task states against Mesos 1.0.0 because the feature didn't exist. We cannot recieve these task states in Mesos 1.1.0 because we do not opt in to these new states. I filed AURORA-1814 to consider opting in.
>
> However, we need to create a mapping because the generated code has the new entries in the enum. I hope this clears up any concerns.
I downgraded Mesos to 1.0 in our Vagrant box and re-run the e2e tests. Everything passed.
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/#review158359
-----------------------------------------------------------
On Dec. 18, 2016, 1:05 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54255/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2016, 1:05 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1813
> https://issues.apache.org/jira/browse/AURORA-1813
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Included changes:
>
> * Handle new task states introduced in the latest Mesos release.
> * Prevent NullPointer exception when inspecting an empty/invalid executor config in a test.
> Probably this is due to a change in the Mesos protobufs.
> * Fix bug preventing the teardown of Vagrant boxes started by the egg build.
> * Increase resources for the Mesos egg builds. The build for all distribution now takes 2h in total.
>
> Full Mesos changelog: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=1.1.0
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126
> RELEASE-NOTES.md 90c4793b218f54ad92ab4da5049d5e92c3a104b3
> Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4
> build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd
> build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca
> build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a
> src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
>
> Diff: https://reviews.apache.org/r/54255/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (run both with Mesos 1.0 and Mesos 1.1)
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 54255: Update to Mesos 1.1.0.
Posted by Zameer Manji <zm...@apache.org>.
> On Dec. 7, 2016, 10:14 a.m., David McLaughlin wrote:
> > Re: Testing Done. Can you verify this build of Aurora also runs on Mesos 1.0.0, even if it's just manual verification? I'm not sure the implication of using those constants - were they also in Mesos 1.0.0?
The constatns were not in the Mesos 1.0.0 protbuf, but they are here now.
We cannot recieve these task states against Mesos 1.0.0 because the feature didn't exist. We cannot recieve these task states in Mesos 1.1.0 because we do not opt in to these new states. I filed AURORA-1814 to consider opting in.
However, we need to create a mapping because the generated code has the new entries in the enum. I hope this clears up any concerns.
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/#review158359
-----------------------------------------------------------
On Dec. 7, 2016, 3:04 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54255/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 3:04 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1813
> https://issues.apache.org/jira/browse/AURORA-1813
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Included changes:
>
> * Handle new task states introduced in the latest Mesos release.
> * Prevent NullPointer exception when inspecting an empty/invalid executor config in a test.
> Probably this is due to a change in the Mesos protobufs.
> * Fix bug preventing the teardown of Vagrant boxes started by the egg build.
> * Increase resources for the Mesos egg builds. The build for all distribution now takes 2h in total.
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126
> RELEASE-NOTES.md 90c4793b218f54ad92ab4da5049d5e92c3a104b3
> Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4
> build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd
> build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca
> build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a
> src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
>
> Diff: https://reviews.apache.org/r/54255/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 54255: Update to Mesos 1.1.0.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/#review158359
-----------------------------------------------------------
Re: Testing Done. Can you verify this build of Aurora also runs on Mesos 1.0.0, even if it's just manual verification? I'm not sure the implication of using those constants - were they also in Mesos 1.0.0?
- David McLaughlin
On Dec. 7, 2016, 11:04 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54255/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 11:04 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1813
> https://issues.apache.org/jira/browse/AURORA-1813
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Included changes:
>
> * Handle new task states introduced in the latest Mesos release.
> * Prevent NullPointer exception when inspecting an empty/invalid executor config in a test.
> Probably this is due to a change in the Mesos protobufs.
> * Fix bug preventing the teardown of Vagrant boxes started by the egg build.
> * Increase resources for the Mesos egg builds. The build for all distribution now takes 2h in total.
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126
> RELEASE-NOTES.md 90c4793b218f54ad92ab4da5049d5e92c3a104b3
> Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4
> build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd
> build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca
> build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a
> src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5
>
> Diff: https://reviews.apache.org/r/54255/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Stephan Erb
>
>