You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/07 03:43:53 UTC

[GitHub] [flink] deadwind4 commented on a diff in pull request #19732: [FLINK-18887][python][connector/elasticsearch] Add Elasticsearch DataStream API

deadwind4 commented on code in PR #19732:
URL: https://github.com/apache/flink/pull/19732#discussion_r890738562


##########
flink-python/pyflink/datastream/connectors/__init__.py:
##########
@@ -48,6 +50,10 @@
     'JdbcExecutionOptions',
     'NumberSequenceSource',
     'OutputFileConfig',
+    'ElasticsearchSink',
+    'Elasticsearch6SinkBuilder',
+    'Elasticsearch7SinkBuilder',
+    'FlushBackoffType',

Review Comment:
   > All the classes added in the future are placed in connector specific files
   This makes sense to me. All classes in each connector keep unifying.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org