You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "david-kariuki (via GitHub)" <gi...@apache.org> on 2023/04/19 19:32:45 UTC
[GitHub] [fineract] david-kariuki opened a new pull request, #3137: Capitalized titles and line breaks
david-kariuki opened a new pull request, #3137:
URL: https://github.com/apache/fineract/pull/3137
Capitalize major titles and add line breaks to increase readablity
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] david-kariuki commented on pull request #3137: Capitalized titles and line breaks
Posted by "david-kariuki (via GitHub)" <gi...@apache.org>.
david-kariuki commented on PR #3137:
URL: https://github.com/apache/fineract/pull/3137#issuecomment-1516736977
> @david-kariuki Please attach a FINERACT jira story number to your PR and commit!
How do I go about this? I made these changes on Github's markdown editor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #3137: FINERACT-1714: Capitalized titles and line breaks
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3137:
URL: https://github.com/apache/fineract/pull/3137#issuecomment-1518828879
@david-kariuki Unfortunately, we cannot merge this into this way. When you merged the latest changes into your branch, you havent rebased it, rather used merge strategy. The problem is this way it would override the develop branch git history...That is the reason why it shows all the changes which were done by others as part of your PR.
Would you please checkout the latest version of develop and apply your changes on it? Or rebase your branch with the latest develop branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #3137: FINERACT-1714: Capitalized titles and line breaks
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3137:
URL: https://github.com/apache/fineract/pull/3137#issuecomment-1517551107
@david-kariuki I dont think you can do it from there. Is it possible to checkout the project into your machine and squash the commits and push them back for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #3137: Capitalized titles and line breaks
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3137:
URL: https://github.com/apache/fineract/pull/3137#issuecomment-1515285019
@david-kariuki Please attach a FINERACT jira story number to your PR and commit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] david-kariuki commented on pull request #3137: FINERACT-1714: Capitalized titles and line breaks
Posted by "david-kariuki (via GitHub)" <gi...@apache.org>.
david-kariuki commented on PR #3137:
URL: https://github.com/apache/fineract/pull/3137#issuecomment-1518291936
> @david-kariuki Please squash you commits!
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] david-kariuki commented on pull request #3137: FINERACT-1714: Capitalized titles and line breaks
Posted by "david-kariuki (via GitHub)" <gi...@apache.org>.
david-kariuki commented on PR #3137:
URL: https://github.com/apache/fineract/pull/3137#issuecomment-1518889017
I will checkout from the latest version and make new changes. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #3137: Capitalized titles and line breaks
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3137:
URL: https://github.com/apache/fineract/pull/3137#issuecomment-1516307443
@david-kariuki Please squash you commits!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] david-kariuki closed pull request #3137: FINERACT-1714: Capitalized titles and line breaks
Posted by "david-kariuki (via GitHub)" <gi...@apache.org>.
david-kariuki closed pull request #3137: FINERACT-1714: Capitalized titles and line breaks
URL: https://github.com/apache/fineract/pull/3137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org