You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/21 13:10:46 UTC

[GitHub] [flink] wuchong commented on a change in pull request #13634: [FLINK-19629]Fix NullPointException in avro format as null value on MAP type

wuchong commented on a change in pull request #13634:
URL: https://github.com/apache/flink/pull/13634#discussion_r509264169



##########
File path: flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroRowDataDeSerializationSchemaTest.java
##########
@@ -198,4 +198,38 @@ public void testSpecificType() throws Exception {
 		Assert.assertEquals("12:12:12", DataFormatConverters.LocalTimeConverter.INSTANCE.toExternal(
 				rowData.getInt(2)).toString());
 	}
+
+	@Test
+	public void testNullableMapType() throws Exception {

Review comment:
       We don't need to add such a big test. You can just add a null entry to the `map` in the `testSerializeDeserialize`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org