You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/04/04 02:38:27 UTC

[GitHub] ccollins476ad commented on a change in pull request #147: Cmake fixes

ccollins476ad commented on a change in pull request #147: Cmake fixes
URL: https://github.com/apache/mynewt-newt/pull/147#discussion_r179012761
 
 

 ##########
 File path: newt/builder/cmake.go
 ##########
 @@ -84,10 +84,20 @@ func (b *Builder) CMakeBuildPackageWrite(w io.Writer, bpkg *BuildPackage) (*Buil
 
 	files := []string{}
 	for _, s := range entries {
+		filename := filepath.ToSlash(s.Filename)
+		if s.Compiler.ShouldIgnoreFile(filename) {
+			fmt.Printf("Ignoring %s because package dictates it.\n", filename)
 
 Review comment:
   This should be `log.Infof()` or `util.StatusMessage()`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services