You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/05/10 05:44:58 UTC
[jira] [Commented] (SHINDIG-1772)
gadgets.io.RequestParameters.SIGN_OWNER and
gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
[ https://issues.apache.org/jira/browse/SHINDIG-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272062#comment-13272062 ]
jiraposter@reviews.apache.org commented on SHINDIG-1772:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5085/
-----------------------------------------------------------
Review request for Ryan Baxter, Dan Dumont and Stanton Sievers.
Summary
-------
The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
This addresses bug shindig-1772.
https://issues.apache.org/jira/browse/shindig-1772
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1327432
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js 1327432
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1327432
Diff: https://reviews.apache.org/r/5085/diff
Testing
-------
Update iotest.js
Thanks,
Erik
> gadgets.io.RequestParameters.SIGN_OWNER and gadgets.io.RequestParameters.SIGN_VIEWER not implemented in Shindig
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1772
> URL: https://issues.apache.org/jira/browse/SHINDIG-1772
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and 'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and in fact looks for the wrong parameters. In io.js Shindig looks for 'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER' should be made constants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira