You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/11 15:18:48 UTC
[GitHub] shariat commented on a change in pull request #3739: [AIRFLOW-2868]
Extend mesos_executor
shariat commented on a change in pull request #3739: [AIRFLOW-2868] Extend mesos_executor
URL: https://github.com/apache/incubator-airflow/pull/3739#discussion_r209429301
##########
File path: airflow/contrib/executors/mesos_executor.py
##########
@@ -238,15 +290,15 @@ def start(self):
framework.name = get_framework_name()
- if not configuration.conf.get('mesos', 'TASK_CPU'):
- task_cpu = 1
- else:
- task_cpu = configuration.conf.getint('mesos', 'TASK_CPU')
+ task_cpu = configuration.conf.getint('mesos', 'TASK_CPU')
+ task_mem = configuration.conf.getint('mesos', 'TASK_MEMORY')
- if not configuration.conf.get('mesos', 'TASK_MEMORY'):
- task_memory = 256
- else:
- task_memory = configuration.conf.getint('mesos', 'TASK_MEMORY')
+ docker_image = None
+ # Configuration errors when DOCKER_IMAGE_SLAVE is not present in config
+ if 'DOCKER_IMAGE_SLAVE' in configuration.as_dict()['mesos']:
Review comment:
`try: catch:` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services