You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/15 07:21:40 UTC

[GitHub] [airflow] TobKed opened a new pull request #7173: [AIRFLOW-6565] BigQuery - replace deprecated connection parameters

TobKed opened a new pull request #7173: [AIRFLOW-6565] BigQuery - replace deprecated connection parameters
URL: https://github.com/apache/airflow/pull/7173
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #7173: [AIRFLOW-6565] BigQuery - replace deprecated connection parameters

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7173: [AIRFLOW-6565] BigQuery - replace deprecated connection parameters
URL: https://github.com/apache/airflow/pull/7173
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7173: [AIRFLOW-6565] BigQuery - replace deprecated connection parameters

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7173: [AIRFLOW-6565] BigQuery - replace deprecated connection parameters
URL: https://github.com/apache/airflow/pull/7173#issuecomment-574544458
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7173?src=pr&el=h1) Report
   > Merging [#7173](https://codecov.io/gh/apache/airflow/pull/7173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f7ee687cf9b796685dee0d8ba3142b570248b6e1?src=pr&el=desc) will **decrease** coverage by `0.78%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7173/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7173?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7173      +/-   ##
   ==========================================
   - Coverage    85.4%   84.62%   -0.79%     
   ==========================================
     Files         710      710              
     Lines       39479    39479              
   ==========================================
   - Hits        33718    33409     -309     
   - Misses       5761     6070     +309
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7173?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/gcp/operators/bigquery.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2JpZ3F1ZXJ5LnB5) | `91.59% <100%> (ø)` | :arrow_up: |
   | [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0%> (-72.16%)` | :arrow_down: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=) | `28.16% <0%> (-54.93%)` | :arrow_down: |
   | [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `50% <0%> (-50%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/contrib/sensors/mongo\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbW9uZ29fc2Vuc29yLnB5) | `53.33% <0%> (-46.67%)` | :arrow_down: |
   | [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `49.65% <0%> (-38.78%)` | :arrow_down: |
   | [airflow/contrib/sensors/redis\_key\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcmVkaXNfa2V5X3NlbnNvci5weQ==) | `61.53% <0%> (-38.47%)` | :arrow_down: |
   | ... and [6 more](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7173?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7173?src=pr&el=footer). Last update [f7ee687...c423851](https://codecov.io/gh/apache/airflow/pull/7173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7173: [AIRFLOW-6565] BigQuery - replace deprecated connection parameters

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7173: [AIRFLOW-6565] BigQuery - replace deprecated connection parameters
URL: https://github.com/apache/airflow/pull/7173#issuecomment-574544458
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7173?src=pr&el=h1) Report
   > Merging [#7173](https://codecov.io/gh/apache/airflow/pull/7173?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f7ee687cf9b796685dee0d8ba3142b570248b6e1?src=pr&el=desc) will **decrease** coverage by `0.78%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7173/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7173?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7173      +/-   ##
   ==========================================
   - Coverage    85.4%   84.62%   -0.79%     
   ==========================================
     Files         710      710              
     Lines       39479    39479              
   ==========================================
   - Hits        33718    33409     -309     
   - Misses       5761     6070     +309
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7173?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/gcp/operators/bigquery.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2JpZ3F1ZXJ5LnB5) | `91.59% <100%> (ø)` | :arrow_up: |
   | [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0%> (-72.16%)` | :arrow_down: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=) | `28.16% <0%> (-54.93%)` | :arrow_down: |
   | [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `50% <0%> (-50%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/contrib/sensors/mongo\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbW9uZ29fc2Vuc29yLnB5) | `53.33% <0%> (-46.67%)` | :arrow_down: |
   | [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `49.65% <0%> (-38.78%)` | :arrow_down: |
   | [airflow/contrib/sensors/redis\_key\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcmVkaXNfa2V5X3NlbnNvci5weQ==) | `61.53% <0%> (-38.47%)` | :arrow_down: |
   | ... and [6 more](https://codecov.io/gh/apache/airflow/pull/7173/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7173?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7173?src=pr&el=footer). Last update [f7ee687...c423851](https://codecov.io/gh/apache/airflow/pull/7173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] TobKed commented on issue #7173: [AIRFLOW-6565] BigQuery - replace deprecated connection parameters

Posted by GitBox <gi...@apache.org>.
TobKed commented on issue #7173: [AIRFLOW-6565] BigQuery - replace deprecated connection parameters
URL: https://github.com/apache/airflow/pull/7173#issuecomment-574628371
 
 
   @kaxil I agree with you. Deprecated parameters can still be used, nothing is changed here. I've just replaced usage of the deprecated parameter `bigquery_conn_id` to `gcp_conn_id` in initialisation of `BigQueryHook` in BigQuery operators. I did it because now using BigQuery operators raise deprecation warning which seems unnecessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services