[GitHub] [iceberg] kbendick edited a comment on pull request #1493: Suppress UnnecessaryAnonymousClass warnings for classes with defaultDelete as a Consumer

[GitBox <gi...@apache.org>]

kbendick edited a comment on pull request #1493:
URL: https://github.com/apache/iceberg/pull/1493#issuecomment-699570155


   > Does it fix the warning to use a lambda and cast to `Consumer` instead? This could be something like:
   > 
   > ```java
   > Consumer<String> defaultDelete = (Consumer<String>) file -> io.delete(file);
   > ```
   
   I will look into this now! It would be nice to catch two birds with one stone. I'll also consider Russell's comments as well. I will admit I kept the initial scope of this PR small, as I am still getting fully acquainted with the details of Java functional programming (as I'm definitely more of a Scala dev in my day job). But this is a great opportunity to learn and that's definitely part of why I'm here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org