[GitHub] [incubator-nuttx] anchao commented on pull request #6286: arch: inline up_interrupt_context()

[GitBox <gi...@apache.org>]

anchao commented on PR #6286:
URL: https://github.com/apache/incubator-nuttx/pull/6286#issuecomment-1128934136

   > What are the code size and C89 implication?
   
   @davids5 ,
   
   There is a slight increase in code size, but overall the impact is not very serious
   lm3s6965-ek:qemu-flat(cortex-m):
   
   Before:
   ```
   $ size nuttx
      text	   data	    bss	    dec	    hex	filename
    222304	    324	  14848	 237476	  39fa4	nuttx
   ```
    
    After:
   ```
   $ size nuttx
      text	   data	    bss	    dec	    hex	filename
    222320	    324	  14848	 237492	  39fb4	nuttx
   ```
   
   
   sabre-6quad:smp(Cortex-a9,smp):
   
   Before:
   ```
   $ size nuttx
      text	   data	    bss	    dec	    hex	filename
    127840	    196	  33500	 161536	  27700	nuttx
   ```
   
   After:
   ```
   $ size nuttx
      text	   data	    bss	    dec	    hex	filename
    128096	    196	  33500	 161792	  27800	nuttx
   ```
    
   about C89 compatible, It seems that the current code base can no longer be built with c89 normally(without this PR), too many inline keywords, the inline keyword was added in C99, I think we can use the -std=gnu89 flag instead of -std=c89


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org