You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2016/03/07 20:49:42 UTC

[jclouds] Fixes an intermittently failing swift live test. (#930)

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/930

-- Commit Summary --

  * Fixes an intermittently failing swift live test.

-- File Changes --

    M apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/StaticLargeObjectApiLiveTest.java (2)
    M apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/internal/BaseSwiftApiLiveTest.java (4)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/930.patch
https://github.com/jclouds/jclouds/pull/930.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/930

Re: [jclouds] Fixes an intermittently failing swift live test. (#930)

Posted by Andrew Gaul <no...@github.com>.
> @@ -48,6 +48,10 @@ protected BaseSwiftApiLiveTest() {
>        provider = "openstack-swift";
>     }
>  
> +   protected void awaitConsistency() {
> +      Uninterruptibles.sleepUninterruptibly(5, TimeUnit.SECONDS);

Should this use the `test.blobstore.await-consistency-timeout-seconds` property as used by `BaseBlobStoreIntegrationTest`?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/930/files#r55262454

Re: [jclouds] Fixes an intermittently failing swift live test. (#930)

Posted by Zack Shoylev <no...@github.com>.
merged

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/930#issuecomment-193907443

Re: [jclouds] Fixes an intermittently failing swift live test. (#930)

Posted by Zack Shoylev <no...@github.com>.
Thanks @andrewgaul ! I will refactor this a bit, but there are some other swift tests to fix after this, I think. Adding this to swiftproxy is also a good idea - I'll try to look into it some more.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/930#issuecomment-193757955

Re: [jclouds] Fixes an intermittently failing swift live test. (#930)

Posted by Andrew Gaul <no...@github.com>.
@zack-shoylev Relevant, S3Proxy now models eventual consistency: https://github.com/andrewgaul/s3proxy/commit/6292d28c9c66e8f432ae5b18acbadd0c191bc05d.  Easy to add this to [SwiftProxy](https://github.com/bouncestorage/swiftproxy).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/930#issuecomment-193425614

Re: [jclouds] Fixes an intermittently failing swift live test. (#930)

Posted by Zack Shoylev <no...@github.com>.
Closed #930.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/930#event-582153031