You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/10/05 20:22:33 UTC

Review Request 62794: CURRENT cluster Shows Upgrade If Component Didn't Report Version

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62794/
-----------------------------------------------------------

Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-22139
    https://issues.apache.org/jira/browse/AMBARI-22139


Repository: ambari


Description
-------

CURRENT cluster Shows Upgrade If Component Didn't Report Version

STR:
- Install a cluster with 2.6.0.0 and Atlas
- Atlas is busted in this version and doesn't report it's version
- This causes the main install stack to be OUT_OF_SYNC which it should never be since it's the only one.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/script/script.py 829868e03a 


Diff: https://reviews.apache.org/r/62794/diff/1/


Testing
-------

Install of a cluster with a broken component and verified that the stack version is CURRENT after all services reported in.

UNIT TESTS PENDING...


Thanks,

Jonathan Hurley


Re: Review Request 62794: CURRENT cluster Shows Upgrade If Component Didn't Report Version

Posted by Jonathan Hurley <jh...@hortonworks.com>.

> On Oct. 6, 2017, 5:10 a.m., Dmitro Lisnichenko wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py
> > Lines 216 (patched)
> > <https://reviews.apache.org/r/62794/diff/2/?file=1847122#file1847122line216>
> >
> >     instlled

Thanks for the review (and for reading the comments!) ... I've fixed this.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62794/#review187241
-----------------------------------------------------------


On Oct. 5, 2017, 11:16 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62794/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2017, 11:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22139
>     https://issues.apache.org/jira/browse/AMBARI-22139
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> CURRENT cluster Shows Upgrade If Component Didn't Report Version
> 
> STR:
> - Install a cluster with 2.6.0.0 and Atlas
> - Atlas is busted in this version and doesn't report it's version
> - This causes the main install stack to be OUT_OF_SYNC which it should never be since it's the only one.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestScript.py 75726d686d 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 829868e03a 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 665fc202c5 
> 
> 
> Diff: https://reviews.apache.org/r/62794/diff/2/
> 
> 
> Testing
> -------
> 
> Install of a cluster with a broken component and verified that the stack version is CURRENT after all services reported in.
> 
> ----------------------------------------------------------------------
> Total run:1193
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 55.313 s
> [INFO] Finished at: 2017-10-05T23:15:30-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 62794: CURRENT cluster Shows Upgrade If Component Didn't Report Version

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62794/#review187241
-----------------------------------------------------------


Ship it!





ambari-common/src/main/python/resource_management/libraries/script/script.py
Lines 216 (patched)
<https://reviews.apache.org/r/62794/#comment264177>

    instlled


- Dmitro Lisnichenko


On Oct. 6, 2017, 6:16 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62794/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2017, 6:16 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22139
>     https://issues.apache.org/jira/browse/AMBARI-22139
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> CURRENT cluster Shows Upgrade If Component Didn't Report Version
> 
> STR:
> - Install a cluster with 2.6.0.0 and Atlas
> - Atlas is busted in this version and doesn't report it's version
> - This causes the main install stack to be OUT_OF_SYNC which it should never be since it's the only one.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestScript.py 75726d686d 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 829868e03a 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 665fc202c5 
> 
> 
> Diff: https://reviews.apache.org/r/62794/diff/2/
> 
> 
> Testing
> -------
> 
> Install of a cluster with a broken component and verified that the stack version is CURRENT after all services reported in.
> 
> ----------------------------------------------------------------------
> Total run:1193
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 55.313 s
> [INFO] Finished at: 2017-10-05T23:15:30-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 62794: CURRENT cluster Shows Upgrade If Component Didn't Report Version

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62794/#review187263
-----------------------------------------------------------


Ship it!




Ship It!

- Nate Cole


On Oct. 5, 2017, 11:16 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62794/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2017, 11:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22139
>     https://issues.apache.org/jira/browse/AMBARI-22139
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> CURRENT cluster Shows Upgrade If Component Didn't Report Version
> 
> STR:
> - Install a cluster with 2.6.0.0 and Atlas
> - Atlas is busted in this version and doesn't report it's version
> - This causes the main install stack to be OUT_OF_SYNC which it should never be since it's the only one.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestScript.py 75726d686d 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 829868e03a 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 665fc202c5 
> 
> 
> Diff: https://reviews.apache.org/r/62794/diff/2/
> 
> 
> Testing
> -------
> 
> Install of a cluster with a broken component and verified that the stack version is CURRENT after all services reported in.
> 
> ----------------------------------------------------------------------
> Total run:1193
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 55.313 s
> [INFO] Finished at: 2017-10-05T23:15:30-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 62794: CURRENT cluster Shows Upgrade If Component Didn't Report Version

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62794/
-----------------------------------------------------------

(Updated Oct. 5, 2017, 11:16 p.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-22139
    https://issues.apache.org/jira/browse/AMBARI-22139


Repository: ambari


Description
-------

CURRENT cluster Shows Upgrade If Component Didn't Report Version

STR:
- Install a cluster with 2.6.0.0 and Atlas
- Atlas is busted in this version and doesn't report it's version
- This causes the main install stack to be OUT_OF_SYNC which it should never be since it's the only one.


Diffs (updated)
-----

  ambari-agent/src/test/python/resource_management/TestScript.py 75726d686d 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 829868e03a 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py 665fc202c5 


Diff: https://reviews.apache.org/r/62794/diff/2/

Changes: https://reviews.apache.org/r/62794/diff/1-2/


Testing (updated)
-------

Install of a cluster with a broken component and verified that the stack version is CURRENT after all services reported in.

----------------------------------------------------------------------
Total run:1193
Total errors:0
Total failures:0
OK
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 55.313 s
[INFO] Finished at: 2017-10-05T23:15:30-04:00
[INFO] Final Memory: 21M/619M
[INFO] ------------------------------------------------------------------------


Thanks,

Jonathan Hurley